fix: add .rpc for consistency in engine settings #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlastairHolmes
approved these changes
Oct 24, 2023
kylezs
changed the title
Codecov Report
@@ Coverage Diff @@
## main #4158 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 378 378
Lines 60921 60921
Branches 60921 60921
=====================================
- Hits 43749 43744 -5
- Misses 14901 14905 +4
- Partials 2271 2272 +1
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Fixes an inconsistency in the cli config items... need to fix the release docs too to reflect the actual settings.