Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle relative path to db #4164

Merged
merged 5 commits into from Nov 1, 2023
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Oct 26, 2023

Pull Request

Replaces #4142

Ensures that the config root exists and that paths defined in the config file point to actual files where required (key files, mainly).

Tolerates both absolute and relative paths. Relative paths are resolved relative to the config root.

I had to shuffle some of the config test files around and add some dummy key files for the tests.

@dandanlen dandanlen requested a review from a team as a code owner October 30, 2023 15:17
@dandanlen dandanlen requested review from ahasna and tomjohnburton and removed request for a team October 30, 2023 15:17
@dandanlen dandanlen force-pushed the fix/tolerate-relative-db-paths branch from 64a5e93 to 52f93c3 Compare October 30, 2023 16:49
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4164 (bf86d6c) into main (6f5ec83) will increase coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff           @@
##            main   #4164    +/-   ##
======================================
  Coverage     72%     72%            
======================================
  Files        379     379            
  Lines      61670   61792   +122     
  Branches   61670   61792   +122     
======================================
+ Hits       44240   44348   +108     
- Misses     15138   15144     +6     
- Partials    2292    2300     +8     
Files Coverage Δ
engine/src/settings.rs 87% <94%> (+1%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen force-pushed the fix/tolerate-relative-db-paths branch from 8e97eaf to bf86d6c Compare November 1, 2023 09:19
@dandanlen dandanlen enabled auto-merge (squash) November 1, 2023 09:20
@dandanlen dandanlen merged commit d21557a into main Nov 1, 2023
41 checks passed
@dandanlen dandanlen deleted the fix/tolerate-relative-db-paths branch November 1, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants