Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimistic polkadot rotation #4182

Merged
merged 10 commits into from Nov 2, 2023
Merged

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Oct 30, 2023

Cherry picks.

Fixes #4178
Fixes #4171
Fixes #4185

@dandanlen dandanlen changed the title Fix/optimitic-polkadot-rotation feat: optimistic polkadot rotation Oct 30, 2023
@dandanlen dandanlen force-pushed the fix/optimitic-polkadot-rotation branch from 0038769 to cbf300d Compare October 31, 2023 10:43
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #4182 (c36331d) into main (3fafc45) will increase coverage by 0%.
The diff coverage is 69%.

@@          Coverage Diff          @@
##            main   #4182   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        380     380           
  Lines      61841   61818   -23     
  Branches   61841   61818   -23     
=====================================
- Hits       44390   44384    -6     
+ Misses     15149   15119   -30     
- Partials    2302    2315   +13     
Files Coverage Δ
state-chain/cf-integration-tests/src/network.rs 95% <100%> (-<1%) ⬇️
...ain/chains/src/dot/api/batch_fetch_and_transfer.rs 100% <100%> (ø)
...ate-chain/chains/src/dot/api/rotate_vault_proxy.rs 100% <100%> (ø)
state-chain/chains/src/lib.rs 29% <ø> (+5%) ⬆️
state-chain/runtime/src/lib.rs 35% <ø> (ø)
state-chain/chains/src/dot/benchmarking.rs 0% <0%> (ø)
...te-chain/pallets/cf-threshold-signature/src/lib.rs 78% <86%> (+<1%) ⬆️
engine/src/witness/dot.rs 28% <43%> (-1%) ⬇️
state-chain/chains/src/dot/api.rs 21% <20%> (+1%) ⬆️
state-chain/runtime/src/chainflip.rs 59% <62%> (+2%) ⬆️
... and 1 more

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen marked this pull request as ready for review October 31, 2023 14:19
state-chain/runtime/src/chainflip.rs Outdated Show resolved Hide resolved
state-chain/runtime/src/chainflip.rs Show resolved Hide resolved
state-chain/chains/src/dot/api.rs Show resolved Hide resolved
state-chain/chains/src/dot.rs Show resolved Hide resolved
@dandanlen dandanlen enabled auto-merge (squash) November 2, 2023 09:25
@dandanlen dandanlen merged commit b080527 into main Nov 2, 2023
41 checks passed
@dandanlen dandanlen deleted the fix/optimitic-polkadot-rotation branch November 2, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🍒 [HOTFIX] cherry-pick '#4180 - fix allow reporting of new key for optimistic activation' to main
3 participants