feat: lp_subscribe_order_fills (PRO-938) #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlastairHolmes
requested review from
a team and
martin-chainflip
as code owners
AlastairHolmes
requested review from
niklasnatter and
GabrielBuragev
and removed request for
a team
AlastairHolmes
force-pushed
the
feat/subscribe_order_fills
branch
from
db0b117
to
96c619a
Compare
chore: snake case for ApiWaitForResult refactor: factor out wait for result unwrapping refactor: use submit_signed_xt inside the wait_for call feat: withdraw asset wait for refactor: wait for is optional chore: use txhash and txdetails naming
|
@dandanlen Yeah sorry I totally forgot about the old PR, but your comments have been addressed. The old PR was signficantly broken. |
dandanlen
reviewed
Dec 6, 2023
api/bin/chainflip-lp-api/src/main.rs
Outdated
Comment on lines
213
to
214
| hash: Hash, | ||
| number: BlockNumber, |
There was a problem hiding this comment.
nit:
block_hash: Hash,
block_number: BlockNumber,
?
I think this would be a little clearer.
| id, | ||
| .. | ||
| }) => { | ||
| Some((lp.clone(), AssetPair::new(*base_asset, *quote_asset).unwrap(), *id)) |
There was a problem hiding this comment.
Presumably the unwrap is ok because we know it was constructe from a valid base/quote pair when the event was constructed?
kylezs
approved these changes
Dec 6, 2023
dandanlen
approved these changes
Dec 6, 2023
AlastairHolmes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unwraps are annoying, but the behaviour is correct. This behaviour matches other subscriptions in substrate.