Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken contract tests #1

Closed
platocrat opened this issue Jan 10, 2021 · 2 comments
Closed

Broken contract tests #1

platocrat opened this issue Jan 10, 2021 · 2 comments

Comments

@platocrat
Copy link

platocrat commented Jan 10, 2021

Both this project and AAVE-Ether-Escrow suffer from the same bug: an external function call error is thrown by hardhat when running the tests.

Screen Shot 2021-01-10 at 5 09 30 PM

I already confirmed this is an issue with both projects as I was following along with the examples online locally on my mac.

Edit:
Reference to the same issue in AAVE-Ether-Escrow ChainShot/AAVE-Ether-Escrow#1 (comment)

@Dan-Nolan
Copy link
Contributor

Hey @platocrat, thanks for bringing this up and trying out the project!

That error message makes it seem as though it's not forking mainnet. A call to the non-contract account would be happening if it were trying to interact with the AAVE lending pool and the lending pool was not available at the address.

I can replicate this issue if I remove the networks section from the hardhat.config.js. It should work okay out of the gate with the current configuration though. Can you tell if you're running it on a local hardhat network that is not forking mainnet?

@platocrat
Copy link
Author

Ah, that makes sense. Yes, I was not forking mainnet (skipped that section in the README 😅).
Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants