Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu] [Vue]: slot props #905

Closed
jiblett1000 opened this issue May 7, 2023 · 4 comments
Closed

[Menu] [Vue]: slot props #905

jiblett1000 opened this issue May 7, 2023 · 4 comments
Assignees

Comments

@jiblett1000
Copy link

Description

Just like was done for the Select component #831

Please expose slot props for isOpen and the highlightedItem (or whatever it should be named) state.

Proposed Solution or API

N/A

Additional Information

No response

@TylerAPfledderer
Copy link
Collaborator

Hey @jiblett1000 !

Thank you for pointing this out and the indirect reminder about exposing the api! I'll make this my next assignment to look over all the components to ensure the related api's are exposed to the v-slot where needed.

We might still be considering the addition of using the expose method for added flexibility. :)

@jiblett1000
Copy link
Author

@TylerAPfledderer All sounds great! definitely adding/using expose couldn't hurt 😄

@jiblett1000
Copy link
Author

@TylerAPfledderer BTW, I guess I'll just wait for #913 to resolve before posting more slot prop related issues. Seems like it might be kind of redundant at this point. 🤔

@ploca14
Copy link

ploca14 commented Jul 20, 2023

I think the MenuItem should expose isHighlighted through slot props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants