-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider onChangeEnd doesn't get triggered when clicking and triggered twice when dragging #3860
Comments
Reopened this one as I reproduced it again. Thought it was working, but it was a weird error in the sandbox not using the latest version of chakra. |
I'm having the same problem, don't know why is happening |
Yes, still happening. Sadly, I haven't found a workaround for this. This is my use case: I have a form where I need to go into the next step of the form right after the onChangeEnd event fires. But as the event is triggered at the start and end, users can't event drag the slider when they are moved into the next step. And when clicking, event doesn't trigger, so it's kind of weird :( |
I am getting the same issue as well: https://codesandbox.io/s/confident-jackson-zlg17?file=/src/App.tsx but I'm using Chakra 1.6.0 |
I just pushed a fix for this. We'll release an update shortly. If the issue persists after upgrading, I'll re-open it. |
I'm sorry to say it, but I believe that the problem persists: https://codesandbox.io/s/aged-browser-4df3l?file=/src/App.js |
This seems to be a regression bug. It works on 1.6.5 (doesnt on 1.6.6) https://codesandbox.io/s/damp-sea-7oc2x @segunadebayo Possible that this fix may caused the onChangeEnd to not trigger when clicking on a slider track. This is not an issue in 1.6.5 (view codesandbox link) |
Hello, Using 1.6.5 it works, except when going from a boundary to 50% : from any %, click on 50% => onChangeEnd is triggered correctly Not sure if its related to 1.6.6 bug NB : 50% is the original default value in the test. Edit : some other starting values seems to also be buggy but destination is always 50%. |
馃悰 Bug report
Slider onChangeEnd event doesn't get triggered when clicking in the slider track.
Also, when dragging event gets triggered twice (at start and at the end).
馃挜 Steps to reproduce
馃捇 Link to reproduction
CodeSandbox reproduction: https://codesandbox.io/s/nervous-almeida-pzbmm?file=/pages/index.tsx
馃 Expected behavior
馃實 System information
馃摑 Additional information
Also tested this in Firefox and Chrome, is happening too.
Any way I can provide more information let me know. :)
The text was updated successfully, but these errors were encountered: