Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergeConfigs esbuild warning on panda codgen (@pandacss/config) #2502

Closed
1 of 3 tasks
jonambas opened this issue Apr 12, 2024 · 1 comment
Closed
1 of 3 tasks

mergeConfigs esbuild warning on panda codgen (@pandacss/config) #2502

jonambas opened this issue Apr 12, 2024 · 1 comment

Comments

@jonambas
Copy link

jonambas commented Apr 12, 2024

Description

Using mergeConfigs from @pandacss/config produces a warning on panda codegen. Not a huge issue, codegen completes properly, but a warning gets printed to the terminal.

Example codesandbox here

Warning:

[WARNING] "esbuild" should be marked as external for use with "require.resolve" [require-resolve-not-external]

    node_modules/.pnpm/esbuild@0.20.2/node_modules/esbuild/lib/main.js:1825:36:
      1825 │   const libMainJS = require.resolve("esbuild");

Example:

import { defineConfig } from "@pandacss/dev";
import { mergeConfigs } from "@pandacss/config";

export default defineConfig(
  mergeConfigs([
    {
      preflight: true,
      include: ["./app/**/*.{ts,tsx,js,jsx}"],
      exclude: [],
      outdir: "styled-system",
    },
    { shorthands: false },
  ]),
);

Link to Reproduction

https://codesandbox.io/p/devbox/next-app-panda-dc4lcv

Steps to reproduce

Run panda codegen
You should see a warning:

[WARNING] "esbuild" should be marked as external for use with "require.resolve" [require-resolve-not-external]

JS Framework

No response

Panda CSS Version

0.37.2

Browser

No response

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

No response

@jonambas
Copy link
Author

Closing sorry 😓
Looks like importing import { mergeConfigs } from "@pandacss/config/merge"; resolves the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant