-
Notifications
You must be signed in to change notification settings - Fork 1k
Reinstate old UI and website link #151
Comments
@atomiks, not really. But you could help iron out issues.
Basically if you can pr a fix for the js and overflow problems, I will take care of the rest. We are planning a launch next week to go hand in hand with the start of the new school year, so we should be able to figure it all out till then with your help. I will focus on these issues tomorrow as very high priority. @fejes713 could you help out a little bit? |
For a more detailed explanation as to why not: The Travis builds were failing, GitHub pages had vulnerabilities and a lot of the websites couldn't be updated properly nor would they work with SEO. The point was to get more consistent while retaining individual identity of each repo. After having made these changes we can do a ton more with the new website and we need to remedy issues as we come across them. I definitely appreciate the feedback, but the plan is to move forward not back so we should try and fix problems quickly and once and for all. The proposal is to use the old link from GitHub pages as a redirect to the website via netlify or something similar, which I will do tomorrow and also ask Google to redirect it (I think I know how). Fixing the issues on the site should be easy enough and the scrolling thing could be fixed with some simple redux state control when an element gets clicked, which I can also do tomorrow. |
@atomiks I just updated GitHub pages, old link should redirect to the new website anytime now (ETA: 10-15 minutes to work properly), so that's a big one dealt with. I already asked @fejes713 to check the JS and overflow issues so we can get on them tomorrow morning and I will think of a good solution for the scroll issue, too. If you have any ideas and can help us, I'd love the help. 😉 It's live already, old link redirects to new website now! |
I am currently investigating overflowing issues but can't seem to find any. I know they exist because I found them a couple of days ago, but can't seem to find them now. Could anybody point me to the places of those problems? |
The problem with JavaScript is here: {
cardCodeJs &&
<script>
{`function()(${snippetData.code.js})();`}
</script>
} This doesn't execute JavaScript code. This As far as I know, injecting script tags like this isn't possible probably due to security reasons. Does anyone have an idea of how to approach this? I even tried to execute code directly in the browser ( {
0: '--x',
1: '--y'
} to the |
Some overflow problems with elements in the snippets Seems to only be the "Fullscreen" snippet Some snippets don't gel properly with night mode (as it wasn't accounted for originally) and are hard to see Maybe force the demo part to be white? That would look weird though. + Other things I've noticed
Btw I don't know the code yet so if someone familiar could make these changes instead that would be great 🙏 |
@fejes713 I think I have one idea on how to fix the JS snippet issue, let me take a stab at this and I will report back with results.
|
Update
|
Scroll returning to its last state is something I have been thinking about, I have a proposal but the chances it works might be low. Maybe the scrolly container (instead of the body being scrolled) causes this? Otherwise the scroll position might need to be stored in state and read when navigating back |
@atomiks This is a CSS grid issue at its core. I will use Redux to actually restore the scroll if I can. If you have any other ideas, feel free to pitch in. Meanwhile, I pushed the manual fixes for dark mode on snippets, they should help it all stick together better. I will be looking into the scrolling issue, container style, etc. in the next couple of hours, but I think I can fix it all today. Some of these fixes will probably be applied to all the other repos, too. @atomiks and @fejes713 can either one of you figure out the gradient mouse tracking snippet issue? That one is bothering me and I do not have a lot of ideas... |
I have just updated the css so that the container is actually set up properly and the scrollbar is moved to the far right of the screen so that it won't feel odd. I will push this same update to other repos. Unfortunately, the way it is now set up doesn't seem like the splash logo at the top can span the whole width, but I might have an idea to fix this via CSS. The scroll retention when changing pages will be the last fix I want to push, as it is probably the most complex one. |
I think the gradient one has to do with the var x = e.pageX - btn.offsetLeft // - btn.offsetParent.offsetLeft
var y = e.pageY - btn.offsetTop // - btn.offsetParent.offsetTop Edit: nvm I'm wrong, but it has to do with the |
@atomiks Logo placement and scroll are updated, scroll retention is the only thing missing. We are getting closer! |
This should work: var rect = e.target.getBoundingClientRect();
var x = e.clientX - rect.left;
var y = e.clientY - rect.top; |
Ok, I'll test and update the snippet. |
it works perfectly, @atomiks. Pushing right away. |
The splash header is offset all the way to the right for some reason. I think you need to remove the padding from |
|
@atomiks, wait for the next Netlify deployment to complete and test again in 5 minutes - it should work then. Live and working as expected |
Yup seems good @Chalarangelo Some final CSS polishments:
There's probs more but I can do them later if need be, it should be mostly ready after that |
Will push momentarily.
Will also push momentarily.
Will also push momentarily, I thought it looked cool hanging off the card, but no problem, we'll go with your option.
Will fix as soon as I can, not sure what is not correct there and why.
This is here for two reasons: First, accessibility and second, consistency with other repos. Think about it and get back to me if you are absolutely certain this is redundant.
Also, should be consistent with other repos, but we might actually make these larger org-wide to make them pop more. TL;DR: Give me 20 minutes. |
@atomiks Styles updated as promised. Made minor changes (i.e. At this point, I only need to figure out the scroll memory issue which proves to be a bit of a hassle. i will get back to you on this one, soon. Might require a little more trial and error and I might have to take a break, so I will probably get this done later today. |
I actually did mean to leave it hanging off, just not as much as it was. I should've worded that better. Looks fine now anyway, The splash shape separator still seems to not work, everything else seems good. |
@atomiks Forgot the separator, sorry, will do it right away! 😉 Pushed it already, waiting on the Netlify build I also think it looks better if it doesn't hang off, shadows did look a bit weird actually, so better the way it is. |
Definitely had a nice glow-up overall, thanks @Chalarangelo! (I promise there's no more that I won't do later now):
Since the content is in a scrollable container, you'd probably need to store the |
Also something weird I noticed, is that you need to click the "Night mode" icon directly, even though there's padding around it (which changes to the hand cursor icon), I thought it was buggy. The other icons don't require a "direct" click |
Done
Done
Done (the
Done
I know it's odd, I have it in mind, it's not a dealbreaker but it's something I want to come back and polish up as soon as I can.
I haven't tried this ever, but it sounds plausible. I was pretty much trying to accomplish this by coding it myself, but I'll try your idea first. Wait for the next Netlify build to see changes |
@atomiks I couldn't be more grateful for the suggestion of using the |
Just added the final touches on my last commit, I am closing this as I think I have resolved every single bullet point that was raised here. Thank you so much for all the constructive criticism and feedback on the implementation, it really helps make our work shine! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks. |
@Chalarangelo as far as I'm aware you've recently converted many 30s projects over to new domains and a new starter UI kit. I apologise for being AFK for a few months so I understand you couldn't ask before it transitioned over.
I do like this new UI, however, I think parts of it feel like a beta still and think it could use more polish.
Some big problems I see:
Is it possible to reinstate the old UI and old domain temporarily until these particular kinks are ironed out?
The text was updated successfully, but these errors were encountered: