Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

How do I update a question? #10

Closed
skatcat31 opened this issue May 18, 2018 · 3 comments
Closed

How do I update a question? #10

skatcat31 opened this issue May 18, 2018 · 3 comments

Comments

@skatcat31
Copy link
Contributor

I've noticed the clone an object question is incorrectly using Object.assign:

var a = {} // undefined
var b = Object.assign(a) // undefined
a === b // true

It needs to be updated to the Spread operator or the proper usage of Assign Object.assign({},a)

I'm curious how the setup process for the current generator works, but I'm guessing every question is under the JSON file, but should I just modify the question content in the file? OR is that file generated off of another resource or planned to be in the future?

@fejes713
Copy link
Collaborator

@skatcat31 thanks for pointing that out. Currently, every question is in its own markdown file and contributors are supposed to make changes there. The build.js scripts generates readme file and the extract.js converts those questions into JSON format so @atomiks can build JSX website 👍

@skatcat31
Copy link
Contributor Author

How did I not notice that ENTIRE FOLDER just sitting there labeled questions? Mornings man...

@fejes713
Copy link
Collaborator

Haha, no problem @skatcat31. We are following the same approach here as other 30s repositories are. The main idea is that everyone can contribute everywhere without needing to research repository structure a lot. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants