Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

[CHORE] Linter #25

Closed
Chalarangelo opened this issue Nov 29, 2018 · 7 comments
Closed

[CHORE] Linter #25

Chalarangelo opened this issue Nov 29, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Chalarangelo
Copy link
Owner

We definitely need a linter/formatter for snippets, like eslint + prettier only that it has to work with JSX, too. Can someone please suggest some options and/or help implement them?

@Chalarangelo Chalarangelo added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Nov 29, 2018
@skatcat31
Copy link
Contributor

eslint has a JSX plugin as https://www.npmjs.com/package/eslint-plugin-react that could probably help 😉

@Chalarangelo
Copy link
Owner Author

Alright, I'll get working on it sometime soon.

@meetzaveri
Copy link

meetzaveri commented Dec 2, 2018

I use this config for my projects.

For prettier you have to install it as a devDependency and add a script to it like

"scripts" : { "lint": "prettier -l --config .prettierrc --write \"src/**/*.{js,scss}\" " }

And have .prettierrc file with
{ "printWidth": 100, "tabWidth": 4, "useTabs": true, "jsxBracketSameLine": true }

@fejes713
Copy link
Contributor

fejes713 commented Dec 2, 2018

@meetzaveri good point, but the only problem with this is that our snippet's are stored in .md files, so we need a way to prettier only the parts inside backticks (```jsx);

@meetzaveri
Copy link

Oh @fejes713 ! Got the point.

@meetzaveri
Copy link

meetzaveri commented Dec 3, 2018

We could use MDX format for our markdown files. Source - https://mdxjs.com/

@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants