Add a failing test for extra ansi escapes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you open an issue too, so we can track it? And comment the issue number above the test. |
test.js
Outdated
| @@ -67,3 +67,9 @@ test('weird null issue', t => { | |||
| test('support true color escape sequences', t => { | |||
| t.is(sliceAnsi('\u001B[[1m\u001B[[48;2;255;255;255m\u001B[[38;2;255;0;0municorn\u001B[[39m\u001B[[49m\u001B[[22m', 0, 3), '\u001B[1m\u001B[48;2;255;255;25m\u001B[38;2;255;0;0muni\u001B[39m'); | |||
| }); | |||
|
|
|||
| test.failing('doesn\'t add extra escapes', t => { | |||
| const s = '\u001B[30m\u001B[43m RUNS \u001B[49m\u001B[39m \u001B[32mtest\u001B[39m'; | |||
There was a problem hiding this comment.
Can you include the chalk call used to produce the string in a comment? And use a more descriptive variable name than s.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason when there's a space or multiple spaces at the end,
slice-ansiadds closing escape (\u001b[39m) at the end of the string.