Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for NO_COLOR env var #105

Closed
pieh opened this issue Oct 15, 2019 · 4 comments
Closed

support for NO_COLOR env var #105

pieh opened this issue Oct 15, 2019 · 4 comments

Comments

@pieh
Copy link

pieh commented Oct 15, 2019

Would you accept PR adding support NO_COLOR env var as specified in https://no-color.org?

If so my only question would be which env var should win when both NO_COLOR and FORCE_COLOR would be defined? I suppose FORCE_COLOR should have priority given that it seems to be more established convention?

@Qix-
Copy link
Member

Qix- commented Oct 15, 2019

No, we've been asked this a bunch of times. This would add nothing; FORCE_COLOR is already a bit of a convention in the *nix world. We don't need 10 competing standards.

@pdewacht
Copy link

pdewacht commented Apr 2, 2024

This is a pity, since there is disagreement about the meaning of FORCE_COLOR=0. The site https://force-color.org/ specifies (emphasis added):

When this variable is present and not an empty string (regardless of its value), it should force the addition of ANSI color.

Other projects cite this page and refuse to implement FORCE_COLOR=0 to disable color. NO_COLOR would be unambiguous.

@dcousens
Copy link

dcousens commented Apr 3, 2024

@Qix- isn't the object of this library to account for the emerging standards through it's stated mission of

Detect whether a terminal supports color

The existing implementation is effectively already an attempt to account for a number of community standards around color support declarations using environment variables, of which NO_COLOR is simply another one to add?

@Qix-
Copy link
Member

Qix- commented Apr 3, 2024

There's no "standard" for any of this, and I don't see anywhere where we mention we'll add support for any idea that comes along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants