Question degre de certitude #2485

pielRouge · 2018-04-09T12:57:41Z

Add a new kind of question for the exercises. This new questions is: Multiple answer true false degree certainty.
No changes to the database.
French explanation of the question's behaviour : https://chamilosimsu.wordpress.com/2018/02/07/nouveau-type-de-question-vrai-faux-avec-degres-de-certitude/

Best regards

FlintCIBot · 2018-04-09T13:00:45Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/4662

This comment was posted by FlintCI. It can be disabled in the repository settings.

jmontoyaa · 2018-04-10T07:29:23Z

Please fix the flint issues:

https://flintci.io/repositories/1013/analyses/4662

jmontoyaa · 2018-04-10T07:32:19Z

main/exercise/multiple_answer_true_false_degree_certainty.class.php

+        /**
+         * Constructor
+         */
+        public function MultipleAnswerTrueFalseDegreeCertainty() {


Don't use PHP4 way to create a construct.

use:

public function __construct() { ... }

jmontoyaa · 2018-04-10T07:33:09Z

main/inc/lib/api.lib.php

                    ) {
                        $server_name .= ":".$_SERVER['SERVER_PORT'];
                    }
                    $root_web = $server_protocol.'://'.$server_name.$root_rel;
-                    $root_sys = str_replace('\\', '/', realpath(__DIR__.'/../../../')).'/';
+                    $root_sys = str_replace('\\', '/', realpath(__DIR__ . '/../../ficher test degre certitudes/')).'/';


Delete that line.

jmontoyaa · 2018-04-10T07:33:55Z

main/inc/lib/api.lib.php

@@ -9038,18 +9020,17 @@ function api_float_val($number)
 * 3.141516 => 3.14
 * 3,141516 => 3,14
 *
+ * @todo WIP


Don't delete our changes.

No entiendo

jmontoyaa · 2018-04-10T07:34:03Z

main/inc/lib/api.lib.php

@@ -2033,20 +2035,6 @@ function api_get_course_entity($courseId = 0)
    return Database::getManager()->getRepository('ChamiloCoreBundle:Course')->find($courseId);
 }

-/**


Don't delete our changes

No entiendo

@pielRouge has eliminado el valor por defecto $courseId = 0 en la declaración de la función y el método api_get_session_entity() a bajo. De esto habla Julio.

FlintCIBot · 2018-07-11T13:21:59Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8711

This comment was posted by FlintCI. It can be disabled in the repository settings.

…pleAnswerTrueFalseDegreeCertainty.php

FlintCIBot · 2018-07-11T13:23:40Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8712

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-11T13:26:45Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8713

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-11T13:27:40Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8714

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-11T13:28:56Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8715

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T11:27:08Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8862

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T11:29:16Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8863

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T11:44:20Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8865

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T11:49:51Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8866

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:14:02Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8867

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:15:39Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8868

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:16:45Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8869

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:18:02Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8870

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:18:56Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8871

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2018-07-16T12:22:28Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8872

This comment was posted by FlintCI. It can be disabled in the repository settings.

jmontoyaa · 2018-07-16T13:48:30Z

main/exercise/exercise_submit.php

+                        null,
+                        PERSON_NAME_EMAIL_ADDRESS
+                    );
+                    $emailGenerique = api_get_setting('emailAdministrator');


Changer la variable en anglais $emailGenerique
C'est mieux de metre tout le code dans une fonction, par exemple: "sendQuestionCertaintyNotification()"

FlintCIBot · 2018-07-16T13:50:36Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/8874

This comment was posted by FlintCI. It can be disabled in the repository settings.

ywarnier · 2018-07-16T19:30:04Z

main/exercise/multipleAnswerTrueFalseDegreeCertainty.php

+            $checkResult = ($studentAnwser == $expectedAnswer) ? true : false;
+            if ($checkResult) {
+                if ($studentDegreeChoicePosition >= 6) {
+                    return get_lang('langVerySure');


Les variables de langue ne prennent plus le préfixe "lang" depuis au moins 2 ans 😄
PrettySur->manque un "e" à la fin.
Je corrige tout ça. Ça n'est plus à faire, mais je le note pour la partie "life-long learning" 💡

ywarnier · 2018-07-16T19:31:51Z

main/exercise/multipleAnswerTrueFalseDegreeCertainty.php

+            }
+
+            $data = Database::fetch_assoc($res);
+            $courseCode = $data['exe_cours_id'];


Ceci est incorrect pour les versions 1.11+ au moins. Utiliser $data['c_id'].

ywarnier · 2018-07-16T19:53:42Z

main/inc/lib/exercise.lib.php

@@ -1701,6 +1960,7 @@ public static function get_exam_results_data(
        $courseCode = null,
        $showSessionField = false,
        $showExerciseCategories = false,
+        $userExtraFieldsToAdd = []


Erreur (de parsing, donc étonnant que non détectée)

ywarnier · 2018-07-16T19:57:43Z

main/inc/lib/exercise.lib.php

                                $results[$i]['category_'.$categoryId] = $scoreToDisplay;
                                $results[$i]['category_'.$categoryId.'_score_percentage'] = self::show_score(
                                    $result['score'],
                                    $result['total'],
                                    true,
                                    true,
                                    true, // $show_only_percentage = false
+                                    true // hide % sign


Autre erreur de parsing. Bizarre, quand même, cette idée de dupliquer les paramètres sans raison (et sans virgule)

ywarnier · 2018-07-17T04:16:42Z

Bon, je n'ai pas trouvé le moyen de faire un merge online comme suggérait @jmontoyaa, du coup j'ai créé une branche officielle de Chamilo (temporairement) "certainty" pour essayer d'arriver au bout de ce merge.

Pour l'instant, à quelques petites choses près, ça marche plus ou moins (après 7h de merge quand même 😄 ).

Mais:

quand on est dans cette branche "certainty", le bouton pour sauver la question est bloqué. J'obtiens une erreur JS indiquant que "save_now()" n'est pas une fonction. Pourtant en faisant un diff avec la vraie branche 1.11.x, je ne vois pas de différence notoire. Une idée?
il y a une variable JS qui est ajoutée à une URL mais qui n'est pas définie. J'ai laissé une note à @baelmyhu dans le PR à ce sujet
quand j'essaie de passer un autre type de question (toujours dans la branche), je reçois deux NOTICE qui viennent de la classe du nouveau type de question (alors que normalement on ne rentre pas dans ce code):
Notice: Undefined offset: 1 in /var/www/chamilo111x/main/exercise/multipleAnswerTrueFalseDegreeCertainty.php on line 1038
et
Notice: Undefined offset: 2 in /var/www/chamilo111x/main/exercise/multipleAnswerTrueFalseDegreeCertainty.php on line 1041

Voilà, donc si @baelmyhu et @pielRouge n'arrivent pas à nous aider sur ceci ce mardi, il faudra abandonner l'intégration dans la 1.11.8 (parce que c'est manifestement du code raccomodé qui n'atteint pas, pour l'instant, le niveau de qualité espéré pour l'intégrer).

Donc merci de travailler directement sur la branche "certainty". J'ouvre un PR pour ça et je ferme celui-ci.

Question degre de certitude

98efe2a

jmontoyaa reviewed Apr 10, 2018

View reviewed changes

AngelFQC force-pushed the 1.11.x branch from ffc1d29 to f94d73a Compare June 14, 2018 22:34

pielRouge added 2 commits July 11, 2018 15:17

Update multiple_answer_true_false_degree_certainty.class.php

34ed68e

Update exercise.lib.php

5907ef4

pielRouge added 2 commits July 11, 2018 15:22

Rename multiple_answer_true_false_degree_certainty.class.php to multi…

e7e2072

…pleAnswerTrueFalseDegreeCertainty.php

Update question.class.php

3d663b2

Update exercise_submit.php

8feed6a

chamilo deleted a comment Jul 11, 2018

pielRouge added 2 commits July 16, 2018 13:23

Update exercise_show.php

d929709

Update exercise_submit.php

e56d374

Update exercise_submit.php

19b85a5

Update api.lib.php

dfc9f56

pielRouge added 5 commits July 16, 2018 14:09

Update api.lib.php

0336826

Update api.lib.php

49fa4b7

Update api.lib.php

c239a31

Update api.lib.php

a34cb58

Update api.lib.php

849e6f6

Update api.lib.php

d6dcd17

Merge branch '1.11.x' into question_degre_certitude_remote

9e89ca4

jmontoyaa reviewed Jul 16, 2018

View reviewed changes

ywarnier reviewed Jul 16, 2018

View reviewed changes

ywarnier closed this Jul 17, 2018

ywarnier mentioned this pull request Jul 17, 2018

Multiple answer with degree of certainty #2591

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Question degre de certitude #2485

Question degre de certitude #2485

pielRouge commented Apr 9, 2018

FlintCIBot commented Apr 9, 2018

jmontoyaa commented Apr 10, 2018

jmontoyaa Apr 10, 2018

jmontoyaa Apr 10, 2018

jmontoyaa Apr 10, 2018

pielRouge Jul 11, 2018

jmontoyaa Apr 10, 2018

pielRouge Jul 11, 2018

ywarnier Jul 13, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

jmontoyaa Jul 16, 2018

FlintCIBot commented Jul 16, 2018

ywarnier Jul 16, 2018

ywarnier Jul 16, 2018

ywarnier Jul 16, 2018

ywarnier Jul 16, 2018

ywarnier commented Jul 17, 2018

Question degre de certitude #2485

Question degre de certitude #2485

Conversation

pielRouge commented Apr 9, 2018

FlintCIBot commented Apr 9, 2018

jmontoyaa commented Apr 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 11, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

FlintCIBot commented Jul 16, 2018

Choose a reason for hiding this comment

FlintCIBot commented Jul 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ywarnier commented Jul 17, 2018