Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detection of user password encryption from database, grant login desp… #4063

Merged
merged 2 commits into from May 4, 2022

Conversation

renaudlemaire
Copy link

Keeping password encrypted in md5 was an issue for a customer of us.
Here are small changes to grant login using password encryption from database and re-encrypt password using configured encryption

…ite configured encryption and re-encrypt password with configured encryption
@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/66159

This comment was posted by FlintCI. It can be disabled in the repository settings.

@ywarnier
Copy link
Member

Nice @renaudlemaire! Given the overhead at login time, I think it would be even nicer to put that under a configuration option (you can see how to define and use one here, for example: https://github.com/chamilo/chamilo-lms/pull/4041/files). Something like $_configuration['password_conversion'] = false; (we always set them to false in the definition, even though they're commented out).
Would you be up to add that additional change?

…version during login if password encryption has changed
@renaudlemaire
Copy link
Author

here it is

@renaudlemaire renaudlemaire removed their assignment May 3, 2022
@ywarnier ywarnier merged commit 7430f5a into chamilo:1.11.x May 4, 2022
@ywarnier ywarnier added this to the 1.11.18 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants