Gh 5434 disable send button on message when title and receivers are not set #5465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change hardcoded url from component to userService so all strings related to endpoints are in the same place
* Add documentation on how to migrate message service
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5465 +/- ##
=========================================
Coverage 39.70% 39.70%
Complexity 10565 10565
=========================================
Files 840 840
Lines 44144 44144
=========================================
Hits 17529 17529
Misses 26615 26615 ☔ View full report in Codecov by Sentry. |
|
Code Climate has analyzed commit ac6f514 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5434
When the user is not able to submit a message, the send button is disabled and this text is shown below:
"Send is disabled because title of message or "to" recipent are not filled in"