Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how Location selector is presented. #1

Open
mtnbarreto opened this issue Feb 25, 2019 · 2 comments
Open

Fix how Location selector is presented. #1

mtnbarreto opened this issue Feb 25, 2019 · 2 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mtnbarreto
Copy link

According to calendar app, location selector is presented from bottom (not as push view controller).
We can provide such configuration but the default behavior should mimic calendar app.

@chamitha chamitha self-assigned this Feb 26, 2019
@chamitha
Copy link
Owner

chamitha commented Feb 26, 2019

@mtnbarreto, I need some assistance with this and perhaps you can direct me towards any docs or examples?
The UISearchController is added to the UINavigationItem.searchController property but a modal presentation has no navigation controller as the PresentationMode uses the PresenterRow type alias that is a UIViewController.
Some custom row implementations add a navigation bar to the view controller xib in Interface Builder instead of using a navigation controller. This does work for a navigation bar with a title view, left and right buttons but the searchController property of its UINavigationItem appears to be ignored. I suspect the logic to use and render the contents of this property MAY be implemented by the navigation controller.
The fallback is to add a UISearchBar (instead of UISearchController) below the navigation bar in Interface Builder. However this is a last resort as it is old fashioned!
The ideal (and simplest) solution would be to present the selector view controller wrapped in a UINavigationController if possible.

@chamitha chamitha added the help wanted Extra attention is needed label Feb 26, 2019
@chamitha
Copy link
Owner

chamitha commented Feb 27, 2019

@mtnbarreto, this is an approach I adopted that perhaps you can review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants