Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

little error in retrieving the normals from the geometry #14

Open
radcheb opened this issue Jul 24, 2014 · 4 comments
Open

little error in retrieving the normals from the geometry #14

radcheb opened this issue Jul 24, 2014 · 4 comments

Comments

@radcheb
Copy link

radcheb commented Jul 24, 2014

In the file "csg.js/csg.js" line48:
vertex = new ThreeBSP.Vertex( vertex.x, vertex.y, vertex.z, face.vertexNormals[2], uvs );

I think we should get the normal from the array vertexNormals with key 1 instead of key 2:

vertex = new ThreeBSP.Vertex( vertex.x, vertex.y, vertex.z, face.vertexNormals[1], uvs );

Thanks,
Radhwane C.

@chandlerprall
Copy link
Owner

Why's that?

@radcheb
Copy link
Author

radcheb commented Jul 31, 2014

Because you should use all the normal while you're using twice the vertexNormals[2].

@Wilt
Copy link
Contributor

Wilt commented Jan 13, 2016

There is already a pull request for this issue here

@chandlerprall
Copy link
Owner

Merged #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants