Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How many action codebases? #3

Closed
Noviny opened this issue Sep 18, 2019 · 2 comments
Closed

How many action codebases? #3

Noviny opened this issue Sep 18, 2019 · 2 comments

Comments

@Noviny
Copy link
Contributor

Noviny commented Sep 18, 2019

Is it better to have one changesets GH action that's configurable with multiple actions, vs having different things for different tasks. The way this was initially set up, I thought we were going to be getting one package, but we've since divided. What's the reasons? Technical or philosophical?

Hypothesis: As a user, it would be good to be able to add the changesets github actions, the configure in one file what actions of it I use.

Downside: Shipping/loading unnecessary code + doing unnecessary work

@emmatown
Copy link
Member

emmatown commented Sep 18, 2019

They’re each doing quite different things with different constraints.

The main thing being that the release action executes user code and trusts that the user code is safe since it’s only run on the base repo code which is important because sensitive secrets are passed.

The check action on the other hand doesn’t execute any user code, it also doesn’t need to be setup with the whole environment of the repo which we need to do because otherwise we’d be exposing a GitHub token to PRs which would Be Bad.


I think it might be possible to write both workflows in one file though, I’ll look into it.

@emmatown
Copy link
Member

emmatown commented Jan 3, 2020

Since we only have one action now, I think we can close this

@emmatown emmatown closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants