Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency range workspace:^ isn't treated as semver range, bumping dependent packages #1290

Open
Pike opened this issue Jan 12, 2024 · 1 comment · May be fixed by #1291
Open

Dependency range workspace:^ isn't treated as semver range, bumping dependent packages #1290

Pike opened this issue Jan 12, 2024 · 1 comment · May be fixed by #1291

Comments

@Pike
Copy link

Pike commented Jan 12, 2024

Affected Packages

  • assemble-release-plan

Problem

Dependents that are specifying their dependency as workspace:^ get their version bumped regardless of the versions.

This is due to workspace:^ being mapped to the dependency range ^ in

changesets/packages/assemble-release-plan/src/determine-dependents.ts

Line 197 in 93ee679

: versionRange.replace(/^workspace:/, ""),

and that's not a valid Range in semver land. And then the check in

changesets/packages/assemble-release-plan/src/determine-dependents.ts

Lines 89 to 92 in 93ee679

!semverSatisfies(
incrementVersion(nextRelease, preInfo),
versionRange
))

fails to detect that the semver satisfies.

Proposed solution

Probably better to replace workspace:^ with "^" + dependencyRelease.oldVersion
Pike added a commit to Pike/changesets that referenced this issue Jan 12, 2024
@Pike
Adhere to semver rules when using workspace:^ dependencies, fixes cha…
4c5d717 
…ngesets#1290
@Pike Pike linked a pull request Jan 12, 2024 that will close this issue
Open
@Rugvip
Copy link
Contributor

Rugvip commented Jan 13, 2024

Wanna chime in that this has been a pain point for us in the Backstage repo, with releases causing a lot of unnecessary version bumps. Painful enough to be annoying, but harmless enough that we haven't prioritized digging into what's going on 😅

Would be awesome to see a fix for this 👍, would help both us and likely a lot of other people publishing releases from workspace monorepos. Also @Pike is a ⭐ from the Backstage community so expecting a quality fix 😁

@Murderlon Murderlon mentioned this issue Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adhere to semver rules when using workspace:^ dependencies, fixes #1290 Pike/changesets
2 participants
@Pike @Rugvip