Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations: "Create new category" button in modal should be disabled when text field is blank or characters don't meet req's #1057

Closed
liaprins-czi opened this issue Nov 22, 2019 · 0 comments · Fixed by #1110
Assignees

Comments

@liaprins-czi
Copy link

liaprins-czi commented Nov 22, 2019

Currently, the "Create new label" button within the modal behaves as expected:

  • disabled at start, before type any characters
  • disables when delete all characters I had typed, so it is an empty field again
  • disables when I have a types a duplicate name of an existing label

However, the "Create new category" button within its modal does not disable ever.

Also, both buttons should disable if I type an un-allowed character (e.g. too many spaces in a row, etc); not sure if this is the current behavior because I'm waiting to see that PR.

label

category

@liaprins-czi liaprins-czi added this to the 0.14.0 milestone Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants