Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user anno - new category names must validate against schema #1112

Closed
bkmartinjr opened this issue Jan 16, 2020 · 0 comments · Fixed by #1114
Closed

user anno - new category names must validate against schema #1112

bkmartinjr opened this issue Jan 16, 2020 · 0 comments · Fixed by #1114
Assignees
Labels

Comments

@bkmartinjr
Copy link
Contributor

See categorical.js::categoryNameError() - the user entered category name is validated for uniqueness against the category names in the categoricalSelection summary object. This object is only guaranteed to have a subset of annotation category names in the schema, so it not detect all collisions. Collisions can occur with continuous annotations, the index, or other categorical annotations not displayed for some other reason (see controlsHelpers.js::selectableCategoryNames() for other logic).

We need to test for name uniqueness in the obs annotation schema, not in the display categories.

@bkmartinjr bkmartinjr added the bug label Jan 16, 2020
@bkmartinjr bkmartinjr added this to the 0.14.0 milestone Jan 16, 2020
@bkmartinjr bkmartinjr self-assigned this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant