Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Continuous features (right-hand-panel) missing in 0.16.4 #1848

Closed
GHAStVHenry opened this issue Sep 17, 2020 · 6 comments
Closed

[BUG] Continuous features (right-hand-panel) missing in 0.16.4 #1848

GHAStVHenry opened this issue Sep 17, 2020 · 6 comments
Assignees
Labels

Comments

@GHAStVHenry
Copy link

Describe the bug
Some continuous features not displaying on 0.16.4 (right hand bar)

To Reproduce
Steps to reproduce the behavior:

  1. run https://cellxgene.cziscience.com/d/6a2facf2-ea03-407b-b73b-82d582da3930.cxg/ data in 0.16.4

Expected behavior
Data displayed with Commit 437fd5f shows 5 features (nCount_RNA, nFeature_RNA, percent.mito, percent.ribo, Stress1)
Data displayed with 0.16.4 shows only 2 features (nCount_RNA, nFeature_RNA)

Screenshots

Version (please complete the following information):

  • Desktop or hosted?: hosted and desktop
  • Browser (if hosted) [e.g. chrome, safari]: chrome
  • Version [e.g. 0.13.0]: 0.16.4

Additional context
Worked in 0.16.2 and older... and works in Commit 437fd5f which is newer than 0.16.4

@GHAStVHenry GHAStVHenry changed the title [BUG] [BUG] Continuous features (right-hand-panel) missing in 0.16.4 Sep 17, 2020
@maniarathi maniarathi self-assigned this Sep 24, 2020
@maniarathi
Copy link
Contributor

Currently vetting the test pypi release before pushing it out! https://test.pypi.org/project/cellxgene/0.16.5rc0/

@brianraymor brianraymor added this to the 2020 Sept 25 - Oct 8 milestone Sep 28, 2020
@signechambers1
Copy link
Contributor

I've confirmed that all 5 expected values nCount_RNA, nFeature_RNA, percent.mito, percent.ribo, Stress1 show up on 0.16.5rc1. This passes my QA, thanks @maniarathi !

@maniarathi
Copy link
Contributor

Moving this back into In Progress since the PR for this fix had to get reverted. The PR didn't account for some constraints on typing in the crossfilter which mean that even though the histograms showed up, they were not brushable.

@maniarathi maniarathi removed their assignment Oct 15, 2020
@seve seve self-assigned this Oct 15, 2020
@lesliecodes lesliecodes modified the milestones: 2020 Sept 25 - Oct 8, 2020 Oct 8 - Oct 22 Oct 19, 2020
@signechambers1
Copy link
Contributor

This passes QA! the correct values show up and i can brush on the right side bar which selects cells.

@maniarathi
Copy link
Contributor

Hi @GHAStVHenry we just pushed out the 0.16.5 release to PyPI so should be fixed now! Thanks for your patience!

@GHAStVHenry
Copy link
Author

confirmed, the features are visible and can be brushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants