Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger API should correctly sort fields in schemas #2983

Closed
brianraymor opened this issue Jul 27, 2022 · 3 comments
Closed

Swagger API should correctly sort fields in schemas #2983

brianraymor opened this issue Jul 27, 2022 · 3 comments
Assignees
Labels
bug Someone made a missteak...

Comments

@brianraymor
Copy link

This was reported very early in the design process and has not been addressed.

The schema should match the ordering in the JSON response.

It's more difficult than it needs to be for users to understand the responses and reviewers to validate the responses. For example:

Screen Shot 2022-07-27 at 12.51.49 PM.png

@brianraymor
Copy link
Author

This is not done. For example, datasets are not sorted in properly:

Screen Shot 2022-08-16 at 3.11.26 PM.png

And X_normalization and X_approximate_distribution are not capitalized in the JSON response or sorted in properly:

Screen Shot 2022-08-16 at 3.16.14 PM.png

@brianraymor
Copy link
Author

brianraymor commented Aug 23, 2022

@Bento007 -My last set of comments are still not addressed?

@brianraymor
Copy link
Author

LGTM @Bento007 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Someone made a missteak...
Projects
None yet
Development

No branches or pull requests

2 participants