Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] echarts camera scroll + React Axis Component Sync #4200

Closed
Tracked by #316
tihuan opened this issue Feb 14, 2023 · 6 comments
Closed
Tracked by #316

[SPIKE] echarts camera scroll + React Axis Component Sync #4200

tihuan opened this issue Feb 14, 2023 · 6 comments
Assignees
Labels
data-viz Data Viz Team frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week SDS Heatmap

Comments

@tihuan
Copy link
Contributor

tihuan commented Feb 14, 2023

  1. As a user, I want to be able to smoothly scroll through the heatmap visualization without any performance issue

  2. As a user, I want to see the row and column labels in the heatmap remain aligned with the data points as I scroll through the visualization.

  3. Potentially contribute to echarts by taking over this PR to add mousepad panning, which I assume we need

  4. Share the spike result with Single Cell and the heatmap group in Slack #sci-heatmap

@tihuan tihuan added frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week SDS Heatmap labels Feb 14, 2023
@tihuan tihuan changed the title echarts camera scroll + React Axis Component Sync [SPIKE] echarts camera scroll + React Axis Component Sync Mar 24, 2023
@dsadgat dsadgat added the data-viz Data Viz Team label Mar 30, 2023
@dsadgat
Copy link
Contributor

dsadgat commented Apr 24, 2023

@masoudmanson have you started work on this?

@masoudmanson
Copy link
Collaborator

masoudmanson commented May 3, 2023

@dsadgat I'll start on this ticket this week during the sprint.

@cathystoli
Copy link
Collaborator

3 story point for the remaining work that is completing the demo that uses that includes the single cell react axis

cc @tihuan and @dsadgat

@masoudmanson
Copy link
Collaborator

masoudmanson commented Jun 21, 2023

Demo and Feature Implementation

  • Synchronizing a custom x-axis component with Apache ECharts.
  • Implementing highlight feature for user interaction.
  • Enabling highlighting of single items, rows, columns, or combinations.
  • Providing live demo at https://apache-echarts-camera-scroll.vercel.app/

The task involves synchronizing a custom x-axis component with Apache ECharts and implementing a highlight feature. Users will be able to highlight individual items, entire rows, entire columns, or combinations of rows and columns. A live demo showcasing these features is available at the provided link.

@tihuan @dsadgat

@tihuan
Copy link
Contributor Author

tihuan commented Jun 21, 2023

Wow this is incredible 🤩 👏 !! Thanks so much for the amazing demo, Masoud!

Also really appreciate you taking the time to go above and beyond to not only test the camera effect, but also highlighting in items, row, column, and cross, as well as producing such a polished interactive demo 🙏

You're amazing!

Looks like camera effect is a go 🚀

@tihuan
Copy link
Contributor Author

tihuan commented Jun 21, 2023

@masoudmanson could you help document your findings on learnings and limitations of this approach, and what areas we might need to spend more time on optimizing please?

For example, the 1500x1500 example is still interactive for scrolling and highlighting, but not as smooth as 1000x1000 or lower. Do you have any ideas on what could be causing the slow down in performance, so we can look out for those?

Originally our assumption was that since camera effect renders a fixed size of items in the window, the interactive performance should be constant regardless of the actual matrix size, but that doesn't seem to be exactly the case. Just wondering if you discovered areas we need to investigate more later 😄

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-viz Data Viz Team frontend Frontend work P1 Priority 1 - Improvement with wide impact, fix within 1 week SDS Heatmap
Projects
None yet
Development

No branches or pull requests

4 participants