Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

5 bundled_rbi related "srb tc" errors in rails_app5_2 repo for gems/sorbet-rails.rbi file #202

Closed
jasnow opened this issue Oct 12, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@jasnow
Copy link
Contributor

jasnow commented Oct 12, 2019

Describe the bug:

5 bundled_rbi related "srb tc" errors in https://github.com/jasnow/rails_app5_2 repo for gems/sorbet-rails.rbi file

Steps to reproduce:

On October 9, when I changed typed from false to true for
sorbet/rbi/gems/sorbet-rails.rbi and ran "srb tc", I got 5 errors.
See gist below for details.
https://gist.github.com/jasnow/b99bc9f4e4ccc5c50b7f219b0767cc78

Today when I repeat it, I get 9 errors.
Ran "srb rbi hidden-definitions" and got it down to 6 errors.
Ran "srb init"/etc again and got it down to the above 5 errors.

All 5 errors appear to be related to the sorbet-rails/bundled_rbi files.
If I comment out the contents of these files, "srb tc" is clean.

Expected behavior:

No errors

Versions:

  • Ruby: 2.4.9p362 (2019-10-02 revision 67824) [x86_64-darwin16]
  • Rails: 5.2.3
  • Sorbet: 0.4.4865
  • Sorbet-Rails: 0.5.7
@jasnow jasnow added the bug Something isn't working label Oct 12, 2019
@jasnow
Copy link
Contributor Author

jasnow commented Oct 19, 2019

If I run "rails rails_rbi:all" and "rails rails_rbi:custom" from my scripts today (as a workaround), I get this added to my hidden.rbi file.

module ITypeAssert
  Elem = ::T.let(nil, ::T.untyped)
end

class TA
  Elem = ::T.let(nil, ::T.untyped)
end

Also sorbet-rails "typed:" goes from "false" to "strong".

@hdoan741
Copy link
Contributor

Seems like this is fixed by running rails_rbi:custom. rails_rbi:all rake task will be kept up-to-date to run all rake tasks needed, including any new rake tasks added or changed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants