Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for granting priviledges in snowflake #13

Closed
wants to merge 1 commit into from

Conversation

ryanking
Copy link
Contributor

I am trying to figure out the resource schemas for granting privileges in snowflake.

Below is a doc where I have some examples of how it could work. Please give feedback.

@ryanking ryanking requested a review from a team as a code owner January 31, 2019 22:03
@codecov
Copy link

codecov bot commented Jan 31, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   76.69%   76.69%           
=======================================
  Files           9        9           
  Lines         665      665           
=======================================
  Hits          510      510           
  Misses         93       93           
  Partials       62       62


# set global privs
resource "snowflake_priviledge_grants" "a" {
name = "foo1"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this name do anything other than provide an ID to track tf state?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just state, because there is no natural ID otherwise.

@austinylin
Copy link
Contributor

A few thoughts:

  • Thanks for starting this!
  • s/priviledges/privileges/g
  • Just wanted to check my understanding, this is just how we assign privileges to roles? Users -> roles is another exercise?
  • I think generally on the questions about how many permissions to enable to be nested in a single grant we should drive towards simplicity which to me would say let's make it easy to grant a ton of access in a single resource. I think that generally means we end up with one resource per role which is cognitively nice.

@ryanking
Copy link
Contributor Author

ryanking commented Feb 4, 2019

  • Thanks for starting this!
  • s/priviledges/privileges/g

Yeah it seems i am unable to spell this work correctly.

  • Just wanted to check my understanding, this is just how we assign privileges to roles? Users -> roles is another exercise?

Yes, there was already a PR and support for the later.

  • I think generally on the questions about how many permissions to enable to be nested in a single grant we should drive towards simplicity which to me would say let's make it easy to grant a ton of access in a single resource. I think that generally means we end up with one resource per role which is cognitively nice.

ok

@ryanking ryanking closed this Feb 14, 2019
ryanking pushed a commit that referenced this pull request Aug 5, 2019
@ryanking ryanking deleted the ryanking/grant_priviledges branch October 9, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants