[fix] reduce spurious diffs to snowflake_view statement #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go modules have gotten good enough that vendoring does not seem worth
the cost any more.
This removes the vendor directory and adds a step to our build to detect
some problems with go.{mod,sum} being out of date.
Make an effort to normalize queries that create views. Snowflake does not preserve formatting when round-tripping these queries, so to compare changes we need to do some normalization. See the comment in the code for limitations.
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
- Coverage 67.87% 67.86% -0.02%
==========================================
Files 46 46
Lines 3088 3087 -1
==========================================
- Hits 2096 2095 -1
Misses 717 717
Partials 275 275
Continue to review full report at Codecov.
|
edulop91
reviewed
Apr 27, 2020
Co-Authored-By: Eduardo Lopez <elopez@chanzuckerberg.com>
kuannie1
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an effort to normalize queries that create views.
Snowflake does not preserve formatting when round-tripping these
queries, so to compare changes we need to do some normalization. See the
comment in the code for limitations.
Test Plan
References