Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] formatting for pr template checklist #172

Merged
merged 2 commits into from
Apr 24, 2020
Merged

[fix] formatting for pr template checklist #172

merged 2 commits into from
Apr 24, 2020

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented Apr 24, 2020 •
edited

Turns out you need '* [ ]' to format a checklist.

Test Plan

  • acceptance tests
  • …

References

@ryanking ryanking requested a review from a team as a code owner April 24, 2020 23:14
jgadling
jgadling suggested changes Apr 24, 2020
View reviewed changes
Copy link

@jgadling jgadling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the second [] isn't displaying correctly

@ryanking
Copy link
Contributor Author

Looks like the second [] isn't displaying correctly

turns out you need some content in the list item

@ryanking ryanking requested a review from jgadling April 24, 2020 23:17
@czimergebot czimergebot merged commit 71cf0f0 into master Apr 24, 2020
@ryanking ryanking deleted the ryanking/fix-pr-template-checklist branch October 9, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgadling jgadling jgadling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanking @jgadling @czimergebot