Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] skip test broken by snowflake #239

Merged
merged 2 commits into from Aug 3, 2020
Merged

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented Aug 3, 2020

Snowflake appears to have changed something which is now causing this
test to fail. Skipping it for now while I find someone who can address
the problem.

cc @henriblancke and @chriskuchin who worked on this originally. Any chance one of you could look at this?

Test Plan

  • acceptance tests

References

Snowflake appears to have changed something which is now causing this
test to fail. Skipping it for now while I find someone who can address
the problem.
@ryanking ryanking requested a review from a team as a code owner August 3, 2020 19:10
@ryanking ryanking requested review from edulop91 and removed request for a team August 3, 2020 19:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020

Codecov Report

Merging #239 into master will decrease coverage by 3.65%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   65.81%   62.16%   -3.66%     
==========================================
  Files          50       50              
  Lines        3698     3698              
==========================================
- Hits         2434     2299     -135     
- Misses        937     1097     +160     
+ Partials      327      302      -25     
Impacted Files Coverage Δ
pkg/resources/task.go 25.06% <0.00%> (-37.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeff3a6...a292aa8. Read the comment docs.

@edulop91 edulop91 removed the bot/merge label Aug 3, 2020
pkg/resources/task_acceptance_test.go Outdated Show resolved Hide resolved
@chriskuchin
Copy link
Contributor

@ryanking I will see if i can find some time in the next couple of days to poke at it

@czimergebot czimergebot merged commit 0902b36 into master Aug 3, 2020
@ryanking ryanking deleted the ryanking/skip-task-acc branch October 9, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants