[feature] ok-to-test allows testing on forked branches with secrets #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking
suggested changes
Dec 2, 2020
Co-authored-by: Ryan King <rking@chanzuckerberg.com>
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
| private_key: ${{ secrets.OK_TO_TEST_PRIVATE_KEY }} | ||
|
|
||
| - name: Slash Command Dispatch | ||
| uses: peter-evans/slash-command-dispatch@v1 |
There was a problem hiding this comment.
there's a v2 for this action, I wonder if worth upgrading (either now or subsequent pr)
There was a problem hiding this comment.
I think we should try using v1 first and then try with v2 since I'm expecting some other things might need to change besides the version number.
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
edulop91
reviewed
Dec 3, 2020
| issue-type: pull-request | ||
| commands: ok-to-test | ||
| named-args: true | ||
| permission: write |
There was a problem hiding this comment.
I wonder how we verify this is enforced
Co-authored-by: Eduardo Lopez <elopez@chanzuckerberg.com>
ryanking
pushed a commit
that referenced
this pull request
Dec 7, 2020
gjv9491
pushed a commit
to gjv9491/terraform-provider-snowflake
that referenced
this pull request
Mar 19, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References:
https://github.com/imjohnbo/ok-to-test
Method:
Copied over the
.github/workflowsfiles and modified to use the preferred method of authentication:Preferred: GitHub App installation access token with contents: write and metadata: read permissionsWe had to follow these instructions to create a new Github App for the
chanzuckerbergorganization, not a personal account app. We were able to create and use theapp idin the app settings and a private key after creating the app. Both are stored in Github secrets now. We changed the githash condition to be more strict than the one written in the original project.