lint cleanup #329
Merged
lint cleanup #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cziie
reviewed
Dec 7, 2020
edulop91
reviewed
Dec 7, 2020
| return err | ||
| } | ||
|
|
||
| // Some properties come from the DESCRIBE INTEGRATION call | ||
| // We need to grab them in a loop | ||
| var k, pType string | ||
| var v, d interface{} | ||
| stmt = snowflake.StorageIntegration(data.Id()).Describe() | ||
| var v, unused interface{} |
edulop91
reviewed
Dec 7, 2020
| @@ -109,7 +109,7 @@ func (gb *FutureGrantBuilder) Share(n string) GrantExecutable { | |||
| // Grant returns the SQL that will grant future privileges on the grant to the grantee | |||
| func (fge *FutureGrantExecutable) Grant(p string, w bool) string { | |||
| var template string | |||
| if w == true { | |||
| if w { | |||
edulop91
approved these changes
Dec 7, 2020
gjv9491
pushed a commit
to gjv9491/terraform-provider-snowflake
that referenced
this pull request
Mar 19, 2021
Note quite to zero lint warnings, but this reduces the lints warnings by a lot. ## Test Plan * [ ] acceptance tests ## References *
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
Note quite to zero lint warnings, but this reduces the lints warnings by a lot. ## Test Plan * [ ] acceptance tests ## References *
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Note quite to zero lint warnings, but this reduces the lints warnings by a lot. ## Test Plan * [ ] acceptance tests ## References *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note quite to zero lint warnings, but this reduces the lints warnings by a lot.
Test Plan
References