Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove resource from state file if its not found #339

Merged
merged 16 commits into from Dec 9, 2020
Merged

[fix] Remove resource from state file if its not found #339

merged 16 commits into from Dec 9, 2020

Conversation

lgwacker
Copy link
Contributor

@lgwacker lgwacker commented Dec 8, 2020

This PR is a redo of #305, since it was missing tests and some resources were not working.

Fixes #188

edwinbdr and others added 5 commits November 19, 2020 09:16
* Adds checks when resources found in the state file are not found in the Snowflake environment. The resources are then removed from the statefile and a warning is produced.
@lgwacker lgwacker requested a review from a team as a code owner December 8, 2020 17:13
@lgwacker lgwacker requested review from ryanking and removed request for a team December 8, 2020 17:13
@lgwacker lgwacker changed the title Add removal of resource from statefile if its not found on Snowflake Add removal of resource from statefile if its not found in Snowflake Dec 8, 2020
@lgwacker lgwacker changed the title Add removal of resource from statefile if its not found in Snowflake Remove resource from statefile if its not found in Snowflake Dec 8, 2020
@lgwacker
Copy link
Contributor Author

lgwacker commented Dec 8, 2020

@ryanking @edulop91 Can we merge this asap? My environment is kinda messy because of this issue. Would help a lot if we can add this to the latest release.

@lgwacker lgwacker changed the title Remove resource from statefile if its not found in Snowflake Remove resource from statefile if its not found in Snowflake (Issue #188) Dec 8, 2020
@ryanking ryanking changed the title Remove resource from statefile if its not found in Snowflake (Issue #188) [fix] Remove resource from state file if its not found Dec 8, 2020
pkg/resources/managed_account_test.go Show resolved Hide resolved
pkg/resources/managed_account.go Outdated Show resolved Hide resolved
@lgwacker
Copy link
Contributor Author

lgwacker commented Dec 9, 2020

@ryanking I don't get why this check error is happening. go.mod is exactly like the one at the master branch.

@ryanking ryanking merged commit 54407e3 into Snowflake-Labs:main Dec 9, 2020
gjv9491 pushed a commit to gjv9491/terraform-provider-snowflake that referenced this pull request Mar 19, 2021
…s#339)

This PR is a redo of Snowflake-Labs#305, since it was missing tests and some resources were not working.

Fixes Snowflake-Labs#188 

Co-authored-by: Edwin De Jong <edwin.de.jong@bigdatarepublic.nl>
Co-authored-by: Ryan King <rking@chanzuckerberg.com>
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
…s#339)

This PR is a redo of Snowflake-Labs#305, since it was missing tests and some resources were not working.

Fixes Snowflake-Labs#188 

Co-authored-by: Edwin De Jong <edwin.de.jong@bigdatarepublic.nl>
Co-authored-by: Ryan King <rking@chanzuckerberg.com>
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
…s#339)

This PR is a redo of Snowflake-Labs#305, since it was missing tests and some resources were not working.

Fixes Snowflake-Labs#188 

Co-authored-by: Edwin De Jong <edwin.de.jong@bigdatarepublic.nl>
Co-authored-by: Ryan King <rking@chanzuckerberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"sql: no rows in result set" error
3 participants