Fix import format for snowflake_database_grant #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, I found same cases which should be fixed and will fix its later. |
|
Fixed in 8cdb7ca |
|
@kanata2 what version was this on? We had a regression in, I think v0.20, related to this which was later reverted. |
|
@ryanking I used v0.18.1, but main branch seems to have the same problem. |
|
I tried |
|
/ok-to-test sha=b29b2b1 |
|
Integration tests success for b29b2b1 |
ryanking
previously requested changes
Feb 3, 2021
* snowflake_database_grant * snowflake_schema_grant * snowflake_table_grant * snowflake_stage_grant * snowflake_warehouse_grant
kanata2
force-pushed
the
fix_database_grant_doc
branch
from
d8ea229
to
c8f9e2e
Compare
|
/ok-to-test sha=c8f9e2e |
alldoami
approved these changes
Feb 8, 2021
|
Integration tests success for c8f9e2e |
|
@kanata2 can you update your branch with main? |
gjv9491
pushed a commit
to gjv9491/terraform-provider-snowflake
that referenced
this pull request
Mar 19, 2021
## Description According to the following code, we must pass 4 or 5 pipe-delimited values in order to use `terraform import`, but the documentation says that you should pass 3 values. Indeed, `terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' works correctly, so I fixed the documentation. https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/a4240bb6bd399141f3614b3a5e1ff54476de70b4/pkg/resources/grant_helpers.go#L114-L116 ### Current Behaviour ``` $ terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' ... snowflake_database_grant.xxx: Refreshing state... [id=xxx|USAGE|false] Error: 4 or 5 fields allowed ```
kanata2
added a commit
to kanata2/terraform-provider-snowflake
that referenced
this pull request
Jul 13, 2021
Same problem as Snowflake-Labs#429. The argument of `grantIDFromString` named `stringID` expects 4 or 5 fields delimitered by "|".
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
## Description According to the following code, we must pass 4 or 5 pipe-delimited values in order to use `terraform import`, but the documentation says that you should pass 3 values. Indeed, `terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' works correctly, so I fixed the documentation. https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/a4240bb6bd399141f3614b3a5e1ff54476de70b4/pkg/resources/grant_helpers.go#L114-L116 ### Current Behaviour ``` $ terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' ... snowflake_database_grant.xxx: Refreshing state... [id=xxx|USAGE|false] Error: 4 or 5 fields allowed ```
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
## Description According to the following code, we must pass 4 or 5 pipe-delimited values in order to use `terraform import`, but the documentation says that you should pass 3 values. Indeed, `terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' works correctly, so I fixed the documentation. https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/a4240bb6bd399141f3614b3a5e1ff54476de70b4/pkg/resources/grant_helpers.go#L114-L116 ### Current Behaviour ``` $ terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' ... snowflake_database_grant.xxx: Refreshing state... [id=xxx|USAGE|false] Error: 4 or 5 fields allowed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the following code, we must pass 4 or 5 pipe-delimited values in order to use
terraform import, but the documentation says that you should pass 3 values.Indeed, `terraform import snowflake_database_grant.xxx 'xxx|||USAGE|false' works correctly, so I fixed the documentation.
https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/a4240bb6bd399141f3614b3a5e1ff54476de70b4/pkg/resources/grant_helpers.go#L114-L116
Current Behaviour