Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] fix doc for snowflake_schema #456

Merged
merged 1 commit into from
Mar 3, 2021
Merged

[doc] fix doc for snowflake_schema #456

merged 1 commit into from
Mar 3, 2021

Conversation

yohei1126
Copy link
Contributor

@yohei1126 yohei1126 commented Feb 18, 2021 •
edited

Test Plan

  • acceptance tests
  • …

References

@yohei1126 yohei1126 requested a review from a team as a code owner February 18, 2021 14:40
@ryanking ryanking requested review from alldoami and removed request for ryanking February 18, 2021 17:10
@yohei1126
Copy link
Contributor Author

@alldoami Would you check this?

@yohei1126 yohei1126 mentioned this pull request Feb 26, 2021
Closed
@alldoami
Copy link
Contributor

/ok-to-test sha=9374bef

@github-actions
Copy link

Integration tests success for 9374bef

alldoami
alldoami approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix conflicts with go.sum

@yohei1126 yohei1126 force-pushed the fix-doc-snowflake-schema branch 2 times, most recently from cb21335 to e87a2a1 Compare February 27, 2021 23:16
@yohei1126
Copy link
Contributor Author

@alldoami done

@edulop91 edulop91 merged commit c633770 into Snowflake-Labs:main Mar 3, 2021
@yohei1126 yohei1126 deleted the fix-doc-snowflake-schema branch March 4, 2021 02:06
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@yohei1126 @anton-chekanov
[doc] fix doc for snowflake_schema (Snowflake-Labs#456)
45aa971
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@yohei1126
[doc] fix doc for snowflake_schema (Snowflake-Labs#456)
86e965f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation for import resource snowflake_schema incorrect
3 participants
@yohei1126 @alldoami @edulop91