provider: read private key from environment variable #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you keep your secrets in Vault (or similar secret manager), you need to render a file for that secret, which complicates things on a serverless platform. It'd be simpler to just export an environment variable instead of managing files. Fixes Snowflake-Labs#471
ryanking
suggested changes
Feb 26, 2021
|
/ok-to-test sha=28109e3 |
|
Integration tests success for 28109e3 |
|
/ok-to-test sha=b5f63f0 |
ryanking
approved these changes
Mar 1, 2021
|
Integration tests success for b5f63f0 |
yohei1126
pushed a commit
to singlife/terraform-provider-snowflake
that referenced
this pull request
Mar 2, 2021
) If you keep your secrets in Vault (or similar secret manager), you need to render a file for that secret, which complicates things on a serverless platform. It'd be simpler to just export an environment variable instead of managing files. Fixes Snowflake-Labs#471
|
@ryanking Thanks for getting this in! Is there an ETA on when this will be released to the TF provider registry? |
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
) If you keep your secrets in Vault (or similar secret manager), you need to render a file for that secret, which complicates things on a serverless platform. It'd be simpler to just export an environment variable instead of managing files. Fixes Snowflake-Labs#471
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
) If you keep your secrets in Vault (or similar secret manager), you need to render a file for that secret, which complicates things on a serverless platform. It'd be simpler to just export an environment variable instead of managing files. Fixes Snowflake-Labs#471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you keep your secrets in Vault (or similar secret manager), you need
to render a file for that secret, which complicates things on a
serverless platform. It'd be simpler to just export an environment
variable instead of managing files.
Fixes #471