Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warehouse_grant: update warehouse grants in-place instead of recreating #478

Merged
merged 6 commits into from
Mar 17, 2021
Merged

warehouse_grant: update warehouse grants in-place instead of recreating #478

merged 6 commits into from
Mar 17, 2021

Conversation

igungor
Copy link
Contributor

@igungor igungor commented Mar 3, 2021

Related to #469
Updates #137

@igungor igungor requested a review from a team as a code owner March 3, 2021 10:47
@igungor igungor requested a review from alldoami March 3, 2021 10:47
@alldoami
Copy link
Contributor

alldoami commented Mar 3, 2021

/ok-to-test sha=31c2162

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Integration tests success for 31c2162

alldoami
alldoami suggested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@alldoami alldoami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also write a test for Update here? Same goes for the other resources you opened a PR for 😄 thank you!

@igungor
Copy link
Contributor Author

igungor commented Mar 9, 2021

Could you also write a test for Update here? Same goes for the other resources you opened a PR for 😄 thank you!

Could you point me to any update grant test or give a hint to how to write update grant test, I'd gladly contribute tests too.

@alldoami
Copy link
Contributor

@igungor here 😄 https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/warehouse_grant_test.go

@igungor
Copy link
Contributor Author

igungor commented Mar 15, 2021

@igungor here 😄 https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/warehouse_grant_test.go

I know where to put the tests, I was expecting a sample resource update-grant test :)

@alldoami
Copy link
Contributor

@igungor ah sorry, we don't have any example tests right now, would you need help writing them?

@alldoami
Copy link
Contributor

/ok-to-test sha=020a98d

@alldoami
Copy link
Contributor

/ok-to-test sha=b6582a5

@github-actions
Copy link

Integration tests success for 020a98d

@github-actions
Copy link

Integration tests success for b6582a5

@alldoami alldoami merged commit fe0ebdb into Snowflake-Labs:main Mar 17, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
@igungor @anton-chekanov
warehouse_grant: update warehouse grants in-place instead of recreati…
c4f1979 
…ng (Snowflake-Labs#478)
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
@igungor
warehouse_grant: update warehouse grants in-place instead of recreati…
bb9383b 
…ng (Snowflake-Labs#478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alldoami alldoami alldoami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igungor @alldoami