Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table_grant: update table grants in-place instead of recreating #480

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

igungor
Copy link
Contributor

@igungor igungor commented Mar 3, 2021

Related to #469
Updates #137

@igungor igungor requested a review from a team as a code owner March 3, 2021 10:48
@igungor igungor requested a review from edulop91 March 3, 2021 10:48
Copy link

@edulop91 edulop91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, otherwise lgtm. Thank you

pkg/resources/table_grant.go Show resolved Hide resolved
@edulop91
Copy link

edulop91 commented Mar 3, 2021

/ok-to-test sha=40ada3c

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

Integration tests success for 40ada3c

@edulop91
Copy link

edulop91 commented Mar 4, 2021

/ok-to-test sha=d11963a

@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Integration tests success for d11963a

@edulop91
Copy link

edulop91 commented Mar 4, 2021

/ok-to-test sha=e90702c

@czimergebot czimergebot merged commit f4dbeea into Snowflake-Labs:main Mar 4, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

Integration tests success for e90702c

@igungor igungor deleted the update-table-grant branch March 9, 2021 11:05
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants