Add new 'api integration' and 'external function' resources

[asaintsever]

• Add support for new snowflake_api_integration and snowflake_external_function resources
• Add unit and acceptance tests
• Add examples & updated documentation

Test Plan

Changes have been compiled and tested successfully (including acceptance tests)

• unit tests
• acceptance tests

References

• https://docs.snowflake.com/en/sql-reference/external-functions-introduction.html
• https://docs.snowflake.com/en/sql-reference/external-functions-creating-aws-options.html
• https://docs.snowflake.com/en/sql-reference/external-functions-creating-azure-options.html
• https://docs.snowflake.com/en/sql-reference/sql/create-api-integration.html
• https://docs.snowflake.com/en/sql-reference/sql/create-external-function.html

[asaintsever]

Hi @edulop91,

Is there something more I should provide to have this PR considered? I saw some PR rotting since several months and I am keen to have those changes merged as we are already making use of these new resources in Terraform configurations.

Thanks in advance for your guidance.
Best.

[alldoami]

Sorry to do this, but would it be possible to separate this PR into two PRs? It is a lot to review 😅

[asaintsever]

@alldoami
Well, it doesn't really make sense to split this contribution into several PR. If not already done, I would suggest you read https://docs.snowflake.com/en/sql-reference/external-functions-introduction.html : it is not possible to create an external function without creating an api integration. They come both at play. For distinct and not related resources, I would have submitted different PR of course but not the case here.

Moreover, by splitting into 2 PR the risk is to merge one and not the other. So you'll have to review both in the end and make sure both are part of same release. Is it what you want?

[alldoami]

Few NITs

[alldoami]

/ok-to-test sha=97cec08

[github-actions]

Integration tests success for 97cec08

[alldoami]

/ok-to-test sha=7e124a9

[github-actions]

Integration tests success for 7e124a9

[alldoami]

I'm looking at the syntax docs on the API Integration and it looks like the API_PROVIDER value should not be in quotes: https://docs.snowflake.com/en/sql-reference/sql/create-api-integration.html#syntax, I think the statement you query wraps the value in quotes.

[asaintsever]

That's true. It turns out that using quotes works fine as it is the case with any query arg/param.
Yet, the documentation states that API_PROVIDER "should not be in quotation marks.". I'll fix that to comply with this requirement.

[alldoami]

/ok-to-test sha=ba8097d

[github-actions]

Integration tests success for ba8097d

[alldoami]

@asaintsever I believe this comment is the same for the external function: #491 (review), seeing it here in the example: https://docs.snowflake.com/en/sql-reference/sql/create-external-function.html#examples.

[asaintsever]

@alldoami sorry I do not understand. What do you mean? As for identifiers, Snowflake accepts both quoted and unquoted forms: https://docs.snowflake.com/en/sql-reference/identifiers-syntax.html

So, except for the API_PROVIDER that should be unquoted as stated by the documentation (even if it works with quotes ...), you are free to have quotes or not.

Moreover, if I look at existing resources like Storage Integration (https://github.com/chanzuckerberg/terraform-provider-snowflake/blob/main/pkg/resources/storage_integration.go), I see STORAGE_PROVIDER and TYPE with quotes in the final SQL request whereas this is not the case in the examples (https://docs.snowflake.com/en/sql-reference/sql/create-storage-integration.html#examples). Again, this is allowed, depends if you want case-sensitive identifiers or not.

[alldoami]

/ok-to-test sha=ff46096

[github-actions]

Integration tests success for ff46096