Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Azure integration - Pipe + Notification Integration #553

Merged
merged 14 commits into from Jun 4, 2021

Conversation

arkadiuss
Copy link
Contributor

@arkadiuss arkadiuss commented May 27, 2021

We needed better Azure integration, there are two useful changes:

  • added 'INTEGRATION' to pipe resource to support also Azure notifications
  • notification integration resource

Test Plan

  • acceptance tests
  • manual tests

Notification integration was only tested with Azure. It wasn't tested with GCP

References

Notification Integration - https://docs.snowflake.com/en/sql-reference/sql/create-notification-integration.html
Pipe - https://docs.snowflake.com/en/sql-reference/sql/create-pipe.html
*

@arkadiuss arkadiuss requested a review from a team as a code owner May 27, 2021 09:24
@arkadiuss arkadiuss requested a review from alldoami May 27, 2021 09:24
@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

Can you run make docs?

@arkadiuss
Copy link
Contributor Author

Sorry I missed that. Docs updated

@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

/ok-to-test sha=5e07f99

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Integration tests failure for 5e07f99

@arkadiuss
Copy link
Contributor Author

Integration tests failure for 5e07f99

Tests should be fixed after last commit

@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=bd59143

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests failure for bd59143

@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

Oops my bad. Can you resolve conflicts and I'll retetst? I just merged another PR.

@arkadiuss
Copy link
Contributor Author

Oops my bad. Can you resolve conflicts and I'll retetst? I just merged another PR.

Sure. Resolved

@alldoami
Copy link
Contributor

alldoami commented Jun 4, 2021

/ok-to-test sha=716c4f8

@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Integration tests success for 716c4f8

@alldoami alldoami merged commit 28bdf96 into Snowflake-Labs:main Jun 4, 2021
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants