Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove snowflake_role_grants name example #561

Merged
merged 1 commit into from Jun 2, 2021

Conversation

dfedde
Copy link
Contributor

@dfedde dfedde commented Jun 1, 2021

name is not a field on the snowflake_role_grants resource making the example invalid if copied exactly.

Test Plan

This is just an example change and does not not currently have any tests other than manually checking the terraform.

References

@dfedde dfedde requested a review from a team as a code owner June 1, 2021 18:24
@dfedde dfedde requested a review from alldoami June 1, 2021 18:24
@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

/ok-to-test sha=654639a

@alldoami
Copy link
Contributor

alldoami commented Jun 1, 2021

Could you run make-docs?

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Integration tests success for 654639a

@dfedde
Copy link
Contributor Author

dfedde commented Jun 2, 2021

I looks like I am doing something wrong or something changed in the way docs get built. make docs is generating doc files with the full name of the resource and not just the part without the provider name in it (docs/resources/database.md -> docs/resources/snowflake_database.md). If this is something I am doing wrong how do I fix this? and if it is a change to the way docs are built should the generated doc changes be committed separately? In this PR?

@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

You can put it in this PR! We did change the way docs are generated. We use https://github.com/hashicorp/terraform-plugin-docs. That change does seem correct though.

`name` is not a field on the snowflake_role_grants resource making the example invalid if copied exactly.
@alldoami
Copy link
Contributor

alldoami commented Jun 2, 2021

/ok-to-test sha=e38687e

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

Integration tests success for e38687e

@alldoami alldoami merged commit a7d2204 into Snowflake-Labs:main Jun 2, 2021
@dfedde dfedde deleted the patch-1 branch June 3, 2021 15:35
jtzero pushed a commit to rxrevu/terraform-provider-snowflake that referenced this pull request Aug 19, 2021
anton-chekanov pushed a commit to anton-chekanov/terraform-provider-snowflake that referenced this pull request Jan 25, 2022
daniepett pushed a commit to daniepett/terraform-provider-snowflake that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants