Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Cannot define KPI with tables which contain '-' in the table name. #793

Closed
bhargavsk1077 opened this issue Mar 7, 2022 · 1 comment · Fixed by #980
Closed

[BUG]: Cannot define KPI with tables which contain '-' in the table name. #793

bhargavsk1077 opened this issue Mar 7, 2022 · 1 comment · Fixed by #980
Assignees
Labels
🛠️ backend 🔗 connectors DB, DW & third party connectors
Milestone

Comments

@bhargavsk1077
Copy link
Contributor

Describe the bug

Defining a KPI with 'Table' as Dataset type and selecting a table which contains a '-' in the table name results in failure.

The issue is observed in the following datasources:

  • Redshift
  • Snowflake
  • Druid

Explain the environment

  • Chaos Genius version: 0.4.1
  • OS Version / Instance: Any
  • Deployment type: Any

Current behavior

Select 'Table' as the Dataset type and select a table which contains '-' in the table name (Example - 'cloud-cost'). Upon clicking 'Add KPI' after selecting other relevant fields we face an error that says - syntax error at or near '-' or unexpected '-'.

Selecting 'Query' as the Dataset type and enclosing the table name in quotes in the query leads to KPI addition being successful.

Expected behavior

KPI Addition should be possible for all such tables with 'Table' as the dataset type.

Screenshots

Screenshot_20220302_155618
Screenshot_20220302_165943

Additional context

To test KPI Addition with Druid as Datasource use the branch 'druid-connector'.

@bhargavsk1077 bhargavsk1077 changed the title [BUG]: Cannot define KPI with a table which contains '-' in the table name. [BUG]: Cannot define KPI with a tables which contain '-' in the table name. Mar 7, 2022
@bhargavsk1077 bhargavsk1077 added 🔗 connectors DB, DW & third party connectors 🛠️ backend labels Mar 7, 2022
@bhargavsk1077 bhargavsk1077 changed the title [BUG]: Cannot define KPI with a tables which contain '-' in the table name. [BUG]: Cannot define KPI with tables which contain '-' in the table name. Mar 7, 2022
@Samyak2 Samyak2 added this to the v0.5.0 milestone Mar 7, 2022
@Samyak2 Samyak2 modified the milestones: v0.5.0, v0.5.1 Mar 15, 2022
@Samyak2 Samyak2 modified the milestones: v0.5.1, v0.6.0 Mar 25, 2022
@Samyak2 Samyak2 modified the milestones: v0.6.0, v0.7.0 Apr 13, 2022
@Samyak2 Samyak2 modified the milestones: v0.7.0, v0.8.0 May 5, 2022
@kartikay-bagla kartikay-bagla linked a pull request Jun 7, 2022 that will close this issue
3 tasks
@Samyak2
Copy link
Contributor

Samyak2 commented Jun 13, 2022

Fixed in v0.8.0

@Samyak2 Samyak2 closed this as completed Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ backend 🔗 connectors DB, DW & third party connectors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants