Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support both field and label selector in Kubernetes collector #56

Closed

Conversation

kelvinguo0210
Copy link
Contributor

Issue:
If the amount of pods reach about 1k in target Kubernetes cluster, the current method to fetch all of pods will be potential to cause CPU SPIKE in API Server.
Enhancement:
2 additional configuration items provided in application.yaml, can be used to limit the search being limited to only one Namespace, to low down the pressure.
Test:
already test in local & UAT env in my company

@kelvinguo0210 kelvinguo0210 changed the title feature: support both field label selector in Kubernetes collector feature: support both field and label selector in Kubernetes collector Jul 19, 2021
Signed-off-by: kelvin.guo <kelvin.guo@homecredit.cn>
@kelvinguo0210 kelvinguo0210 changed the title feature: support both field and label selector in Kubernetes collector feat: support both field and label selector in Kubernetes collector Jul 20, 2021
@kelvinguo0210
Copy link
Contributor Author

#57

@kelvinguo0210
Copy link
Contributor Author

@xcaspar @wayne-pq @cosmic-jc @tiny-x is there anybody help to do PR review? thanks.

@tiny-x
Copy link
Member

tiny-x commented Jul 21, 2021

把 git config 的 user.name 和 user.email 设置你 github 的用户名和邮箱,不然前面那个头像没法显示

@kelvinguo0210
Copy link
Contributor Author

把 git config 的 user.name 和 user.email 设置你 github 的用户名和邮箱,不然前面那个头像没法显示

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants