Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The param timeout for blade cmd #17

Closed
Cenyol opened this issue Apr 1, 2019 · 8 comments
Closed

The param timeout for blade cmd #17

Cenyol opened this issue Apr 1, 2019 · 8 comments
Assignees
Labels
chaosblade-cli chaosblade project good first issue Good for newcomers type/feature Category issues or prs related to feature request.
Milestone

Comments

@Cenyol
Copy link
Contributor

Cenyol commented Apr 1, 2019

Because of the quality of blade, sometime it may lead to us can't interact with target system. For example, we inject network fault with 80% loss rate, and cause we can't connect the server by ssh never. May be the full load for CPU also cause the system couldn't response us at all.

So, we need guardian, and it could terminate something and recover state after we loss control. I think the param 'timeout' may be appropriate our requirement.

blade cpu --timeout 60s ...

blade network --timeout 30s ...

and so on

@Cenyol
Copy link
Contributor Author

Cenyol commented Apr 1, 2019

想要表达的大概是:
timeout参数建议提升到整个blade的级别,而不只是cpu。我之前在对网络进行测试的时候,因为把丢包设置到了80%,导致我ssh连不上,后续只能求助于运维。(估计三次握手就无法完成,因为丢包率太高了)

@wooramel
Copy link

wooramel commented Apr 1, 2019

Thank you for advice, I will think about it 👍

@xcaspar xcaspar added good first issue Good for newcomers type/feature Category issues or prs related to feature request. labels Apr 1, 2019
@aspnetdb
Copy link

aspnetdb commented Apr 1, 2019

'timeout' 参数不仅仅应用在一些极端的场景,还应该是每次故障实验的一个必选操作,甚至就算用户不配置,应该也有一个默认的值(比如:60s),类似sql中的limit。应对上层的演练平台异常、人为疏忽等情况。

@Cenyol
Copy link
Contributor Author

Cenyol commented Apr 1, 2019

'timeout' 参数不仅仅应用在一些极端的场景,还应该是每次故障实验的一个必选操作,甚至就算用户不配置,应该也有一个默认的值(比如:60s),类似sql中的limit。应对上层的演练平台异常、人为疏忽等情况。

You are right, so we lift it to the cmd of blade. Early it was mentioned for cpu sub cmd.

@xcaspar
Copy link
Member

xcaspar commented Apr 1, 2019

'timeout' 参数不仅仅应用在一些极端的场景,还应该是每次故障实验的一个必选操作,甚至就算用户不配置,应该也有一个默认的值(比如:60s),类似sql中的limit。应对上层的演练平台异常、人为疏忽等情况。

I agree. Can I assign this issue to you? @Cenyol

@Cenyol
Copy link
Contributor Author

Cenyol commented Apr 1, 2019

'timeout' 参数不仅仅应用在一些极端的场景,还应该是每次故障实验的一个必选操作,甚至就算用户不配置,应该也有一个默认的值(比如:60s),类似sql中的limit。应对上层的演练平台异常、人为疏忽等情况。

I agree. Can I assign this issue to you? @Cenyol

Ok, you can. ^_^

@xcaspar xcaspar assigned xcaspar and Cenyol and unassigned xcaspar Apr 1, 2019
@wooramel
Copy link

wooramel commented Apr 2, 2019

implemented https://github.com/mingcheng/chaosblade.go/commit/23ad7ae1194501779cedb0c3b9417df12805247f , I will make new PR after #16 is merged.

@xcaspar
Copy link
Member

xcaspar commented Apr 9, 2019

@Cenyol @mingcheng The feature has been implemented in #16 PR which has been merged, I will release it in this week. Thank you all :-)

@xcaspar xcaspar closed this as completed Apr 9, 2019
@xcaspar xcaspar added this to the 0.0.2 milestone Apr 9, 2019
@xcaspar xcaspar added the chaosblade-cli chaosblade project label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chaosblade-cli chaosblade project good first issue Good for newcomers type/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

4 participants