Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates for standardization of files in each WG #278

Merged
merged 5 commits into from May 5, 2021

Conversation

yash-yp
Copy link
Member

@yash-yp yash-yp commented May 3, 2021

Hi everyone,

As discussed in #277, I have created some templates that can serve as a guide on standardizing the files.

The templates are for the following files:

  • README.md
  • CONTRIBUTING.md
  • code-of-conduct.md

Signed-off-by: Yash Prakash yash2002109@gmail.com

Signed-off-by: Yash Prakash <yash2002109@gmail.com>
@GeorgLink
Copy link
Member

Thanks Yash!

The files right now contain a lot of instructions. Could they be changed so that they can be copy-pasted to a new repository without needing changes?

@yash-yp
Copy link
Member Author

yash-yp commented May 3, 2021

Yes @GeorgLink,

I think we can modify the templates so they have minimal instructions. I'll make the required changes.

@GeorgLink
Copy link
Member

It would be great if any instructions we need would be outside the template. Maybe have instructions in handbook?

@yash-yp
Copy link
Member Author

yash-yp commented May 3, 2021

Yes, the instructions can be moved to the handbook. I guess the templates should then only contain the skeletal structure.

I think I need to clarify this, for the README.md we can have a skeletal structure with instructions in the handbook and for the CONTRIBUTING.md/code-of-conduct.md we can have a copy-paste version. Is that right?

@klumb
Copy link
Member

klumb commented May 3, 2021

I agree with @GeorgLink

Signed-off-by: Yash Prakash <yash2002109@gmail.com>
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
@yash-yp
Copy link
Member Author

yash-yp commented May 4, 2021

@GeorgLink, I have made the changes as discussed. Could you please take a look?

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yash2002109

I made some suggestions.

Please remove all <br/>.

templates/CONTRIBUTING.md Outdated Show resolved Hide resolved
templates/CONTRIBUTING.md Outdated Show resolved Hide resolved

Thank you for your interest in contributing :tada:!

The general contributing guidelines can be found in the [community handbook](page-yet-to-be-created)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, let's point to the chaoss/governance repo's Contributing guidelines

@@ -0,0 +1,83 @@
# CHAOSS \<_wg-name_\> Working Group
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# CHAOSS \<_wg-name_\> Working Group
# CHAOSS <wg-name> Working Group

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backslashes are required else the word gets omitted, removed underscores

templates/WG-README.md Outdated Show resolved Hide resolved
templates/WG-README.md Outdated Show resolved Hide resolved
## License

- Link to the `LICENSE` file
- Copyright notice
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright (c) 201x - CHAOSS, a Linux Foundation Project

templates/WG-README.md Outdated Show resolved Hide resolved
templates/code-of-conduct.md Show resolved Hide resolved
templates/code-of-conduct.md Outdated Show resolved Hide resolved
yash-yp and others added 2 commits May 5, 2021 11:13
Signed-off-by: Yash Prakash <yash2002109@gmail.com>

Co-authored-by: Georg J.P. Link <linkgeorg@gmail.com>
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
@yash-yp
Copy link
Member Author

yash-yp commented May 5, 2021

@GeorgLink, I have updated the files as per your suggestions and as finalized in the meet. Could you please take a look?

Copy link
Member

@GeorgLink GeorgLink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @yash2002109

@GeorgLink GeorgLink merged commit 9955544 into chaoss:master May 5, 2021
vchrombie pushed a commit to vchrombie/governance that referenced this pull request Jun 1, 2021
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants