Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request, include on top right in our menu a login/logout button #121

Open
GeorgLink opened this issue Nov 22, 2019 · 5 comments
Open

Comments

@GeorgLink
Copy link
Member

Login buttons are expected to be on the top right.

Feature request: Include on the top right a menu item that says "Login"

That would significantly improve a new-user's experience.

Optional "awesome" extra: the button changes to "Logout" for logged-in users.

@jsmanrique
Copy link

Thank you @GeorgLink for the request. Actually login buttons UX patterns are very diverse, so there is no "where they must be".

I would say that's a Kibana "issue", not a GrimoireLab issue. My recommendation would be to open an issue in upstream Kibana project.

@GeorgLink
Copy link
Member Author

The feature request comes from customer feedback.

Sure, it's a Kibana issue. But 1) I don't see us merging new Kibana features into our downstream version. and 2) we have a custom menu at the top and could implement a login button there.

@jsmanrique
Copy link

My suggestion would be to avoid any development in Kibiter, and ask for any Kibana feature to upstream Kibana.

GrimoireLab is a toolkit to gather, to process, and to consume software development data that relies on some third parties components for a reference implementation, like Elasticsearch, and Kibana.

But users should be available to use other components, specially, for data consumption, like Grafana, Jupiter Notebooks, or even custom JS data visualization frameworks. So, improvements in data visualization tools, should be an issue for such tools, not for GrimoireLab.

@jsmanrique
Copy link

Related: chaoss/grimoirelab#244

@jsmanrique
Copy link

FYI, it seems that in latest versions of Kibana, like the one included in Open Distro for Elasticsearch 1.2, the logout button is in the top right ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants