Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed images and updated links to images #112

Merged
merged 2 commits into from Apr 1, 2021
Merged

Renamed images and updated links to images #112

merged 2 commits into from Apr 1, 2021

Conversation

yash-yp
Copy link
Member

@yash-yp yash-yp commented Mar 29, 2021

While rechecking the repository to ensure it follows the template, in reference to issue #102. I found some images which didn't follow the naming pattern. Fixed them and updated their links in markdown.

Signed-off-by: Yash Prakash yash2002109@gmail.com

@yash-yp
Renamed images and fixed links to images
68a79b7 
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
@yash-yp yash-yp mentioned this pull request Mar 29, 2021
Closed
GeorgLink
GeorgLink requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@GeorgLink GeorgLink left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yash2002109

Please:

  1. change to relative paths
  2. change HTML <img> tags to Markdown

focus-areas/when/burstiness.md Outdated
@@ -45,12 +45,12 @@ There are a number of reasons that may prompt a sudden increase or decrease in t

Augur:

![Augur Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness.augur.png)
![Augur Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness_augur.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Augur Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness_augur.png)
![Augur Burstiness](images/burstiness_augur.png)

focus-areas/when/burstiness.md Outdated


GrimoireLab:

![GrimoireLab Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness.gl.png)
![GrimoireLab Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness_gl.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![GrimoireLab Burstiness](https://raw.githubusercontent.com/chaoss/wg-common/master/focus-areas/when/images/burstiness_gl.png)
![GrimoireLab Burstiness](images/burstiness_gl.png)

focus-areas/when/time-to-first-response.md Outdated
@@ -26,11 +26,11 @@ Time to first response of an activity = time first response was posted to the ac


### Visualizations
![GrimoireLab Panel: Efficiency Timing Overview](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/efficiency_timing_overview.png)
![GrimoireLab Panel: Efficiency Timing Overview](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_efficiency-timing-overview.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![GrimoireLab Panel: Efficiency Timing Overview](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_efficiency-timing-overview.png)
![GrimoireLab Panel: Efficiency Timing Overview](images/time-to-first-response_efficiency-timing-overview.png)

focus-areas/when/time-to-first-response.md Outdated
---------
![Augur Visualization: Time to First Response Heat Map ](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/augur-ttc-1.png)
![Augur Visualization: Time to First Response Heat Map ](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_augur-ttc-1.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Augur Visualization: Time to First Response Heat Map ](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_augur-ttc-1.png)
![Augur Visualization: Time to First Response Heat Map ](images/time-to-first-response_augur-ttc-1.png)

focus-areas/when/time-to-first-response.md Outdated
---------
![Augur Visualization: Mean Response Times](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/augur-ttc-2.png)
![Augur Visualization: Mean Response Times](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_augur-ttc-2.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Augur Visualization: Mean Response Times](https://github.com/chaoss/wg-common/blob/master/focus-areas/when/images/time-to-first-response_augur-ttc-2.png)
![Augur Visualization: Mean Response Times](images/time-to-first-response_augur-ttc-2.png)

focus-areas/when/activity-dates-and-times.md Outdated Show resolved Hide resolved
@yash-yp
Changed image syntax
eadf8f5 
Signed-off-by: Yash Prakash <yash2002109@gmail.com>
@yash-yp
Copy link
Member Author

yash-yp commented Mar 29, 2021

Hi @GeorgLink,
I made the changes as suggested. Please review.

@yash-yp yash-yp requested a review from GeorgLink March 29, 2021 23:06
@sgoggins sgoggins merged commit 023ebb0 into chaoss:master Apr 1, 2021
@GeorgLink GeorgLink mentioned this pull request Apr 1, 2021
Closed
@yash-yp yash-yp deleted the yash2002109-patch-2 branch May 14, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgLink GeorgLink Awaiting requested review from GeorgLink

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yash-yp @GeorgLink @sgoggins