Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v1.4 new features #26

Closed
Charca opened this issue Mar 2, 2017 · 7 comments
Closed

Support v1.4 new features #26

Charca opened this issue Mar 2, 2017 · 7 comments
Assignees

Comments

@Charca
Copy link
Owner

Charca commented Mar 2, 2017

Messenger Platform 1.4 is out today with a lot of juicy new updates!

Make sure we support all of them: https://messengerblog.com/platform-updates/messenger-platform-1-4-brings-even-more-tools-to-build-great-experiences/

@Ltty
Copy link
Contributor

Ltty commented Mar 4, 2017

Do you already have a timeline for the updated API?

@Charca
Copy link
Owner Author

Charca commented Mar 17, 2017

Hey @Ltty, thanks again for your contribution. Your PR takes care of all updates for the new Messenger Profile API, so after we merge that, we should be good to go!

The only new feature we need to support is the image_aspect_ratio prop in sendGenericTemplate() (docs). I can take care of that in a separate PR.

@temrysh
Copy link

temrysh commented Mar 23, 2017

What about referral param?
https://developers.facebook.com/docs/messenger-platform/referral-params
Maybe it could be handful to have an emitter for that?

@Charca
Copy link
Owner Author

Charca commented Mar 28, 2017

@tmwd I've just added support for the referral event in df179c5

Once we merge @Ltty's PR we'll be able to close this issue.

@temrysh
Copy link

temrysh commented Apr 12, 2017

@Charca
Since there is no way to handle event if its not in the release, maybe it will be useful to have default handler for unknown events?

@Charca
Copy link
Owner Author

Charca commented Apr 13, 2017

@tmwd I've just published v1.0.11 that should give you the ability to listen for the referral event with bot.on('referral', callback).

As for the generic "catch-all" handler for unknown events, I'd prefer to keep it controlled for now. I wouldn't like people to use this event for new features and never switching to the actual event when the framework adds support for it. Also this event wouldn't generate a Chat instance because we couldn't guarantee that there's a sender object in the payload.

If in the future Facebook starts adding events faster than we can keep up with, I can consider adding it, but for now I'd rather keep it under control. Thanks for the suggestion, though!

@Charca
Copy link
Owner Author

Charca commented Apr 14, 2017

v1.0.12 released with full support for Messenger v1.4: https://github.com/Charca/bootbot/releases/tag/v1.0.12

@Charca Charca closed this as completed Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants