Add Python 3 support (and drop support for < 2.6) #9
Conversation
Converted code using steps as described at http://getpython3.com/diveintopython3/case-study-porting-chardet-to-python-3.html.
Regular expression substitution was being given bytes and strings inconsistently. Now takes bytes and correctly identifies test documents.
…rly closed for README.
|
I'm not really; I was kind of a drive-by patcher myself, but I saw no one else had a DVCS repo for it, and I managed to finagle maintainer privs on the PyPI entry, which hadn't been updated in forever. You seem like you care about the project. Would you like to maintain it? In fact, you've been drafted. ;-) I gave you commit privs on my repo. Do what you like, say "go", and I'll cut a release. Cheers! On Dec 10, 2013, at 3:39 PM, Dan Blanchard notifications@github.com wrote:
|
|
Thanks! I'll see if I can get Travis-CI setup with the unit tests from #4 and then we can automatically check if all the PRs actually work. 😄 |
|
Good first step! |
|
I actually discovered a while after making that fork that there was an effort to maintain a 2-and-3-compatible version. It's called charade: https://github.com/sigmavirus24/charade. I'm not sure if it's kept in sync with chardet though (or whether chardet itself is being maintained for that matter). You may want to reach out to @sigmavirus24 about it. |
|
Interesting... maybe we should just redirect people to using that then? I mean, if |
|
I have been doing an awful job of keeping it up to date with anything. We have 26 failing tests that were failing when I forked the repo. Pull requests are extraordinarily welcome and if anyone would like to help maintain it, please let me know. I'm kind of overwhelmed since I've started planning out how to bring PyYAML up-to-date with the current day. |
|
Since more people know the name |
|
One word of warning @dan-blanchard: charade currently only supports 2.6, 2.7, 3.2, and 3.3 because that's all requests needs. If we merge, the changes which make it work on those might break compatibility with 2.5 if anyone cares about that. Does anyone have any opinions on this before I submit the PR? |
|
Also, I removed the necessity to install the script to |
|
I have no love for 2.5, and this PR already drops support for it, so it's fine by me. IMHO, it's time for people to move on to Python 3. |
|
I'll get around to this tomorrow most likely. If you would rather, feel free to create the PR yourself, since you should be able to select that as the HEAD for comparison. I'd rather use a separate branch so PR review can be addressed there. |
@sigmavirus24, you mean you'll create a separate branch on the charade repo and create a PR from that branch into the master branch here? Speaking of branches, this may be a conversation for another day, but I think switching to gitflow for our workflow would be nice. It's what I use on all my other repos. Actually, I just looked and it appears that's what you're using for charade (at least, you have separate develop and master branches which make me think so). So since @erikrose is pretty flexible about the direction we take things, I'm going to assume he won't mind that switch. 😄 I'll create a develop branch for you to select as the HEAD for comparison (it'll have the same content as the current master). |
|
That's exactly what I mean. I'm on my way into work and I have plans at lunch, but I should be able to take care of this tonight. |
|
Okay, cool. The |
|
You guys rock; I'm enjoying watching the show. @dan-blanchard, let me know if anybody else needs privs. If this really takes off, we can always move it to a team-owned account like nose and pypa do to save management bottleneck. |
|
Frankly I've been trying to find someone interested in taking over charade for me for quite some time now. I'll help administer the repository and get debugging information but frankly my interest in maintaining the library as a whole is not very high. That said, I don't see at the moment that y'all have set up Travis with this repository. That's something I had set up with charade and for which you'll just need to flip a switch to enable. Let me know if you run into any issues with that and if you'd still like me to stick around. |
|
@sigmavirus24, I've only very recently joined the chardet team, and getting Travis setup was very high on my to-do list, so I'm glad that you've already got that setup. Anyway, it's true that for all of use chardet/charade is not a huge priority, so I'm not sure how much we can expect to see development pick up even after this merger, but at least there will be more people begrudgingly getting the things done that need to get done. 😄 It's also possible that after |
|
Closing this, since it was superseded by #10. |
Most of the credit for this goes to @bsidhom. I just took his Python 3 port and added a bunch of
__future__imports and the occasionalfrom io import opento make it backward compatible with 2.6 and 2.7.I did some minor clean-up things like sorting imports and things like that. Oh and I added a
.gitattributesfile to ensure line endings are consistent.@erikrose Are you still actively maintaining this? I notice there a few outstanding pull requests and I just want to make sure the version on PyPI is 2/3 compatible soon.