-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you accept a contribution with redesigned client? #50
Comments
As an example of a nice library design we would like to achieve: https://github.com/mailgun/mailgun-php |
Hello Chargebee maintainers, @cb-yateshmathuria @cb-khushbubibay Do you have any thoughts about this? |
Hi @Wojciechem @Arminek |
Very interested in this as well, we need to inject a custom HTTP client. |
Apologies, I did not have the capacity to look at it yet, but I will try to work on the fork next week :) |
Not a proper redesign, but I made some refactoring to address the points from my issue. |
bump 😉 |
Hello Chargebee,
We've been having problems testing the client API provided with the Chargebee SDK, and for the past few meetings we've been thinking about modernizing the code to make it more testable.
It would greatly improve our experience of integrating with Chargebee. Currently we implement the required abstraction in our code, but the possibilities are limited this way. We feel that improving the open source client is more future-proof and beneficial than re-writing the API integration on our side.
Main points we would like to address with such redesign are:
Would you be interested in such a contribution?
The text was updated successfully, but these errors were encountered: